All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guillaume GARDET - Oliséo" <guillaume.gardet@oliseo.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.
Date: Wed, 22 Jul 2015 15:30:54 +0200	[thread overview]
Message-ID: <55AF9B0E.8080803@oliseo.fr> (raw)
In-Reply-To: <20150722145503.01f5bd26@free-electrons.com>

Le 22/07/2015 14:55, Thomas Petazzoni a ?crit :
> Guillaume,
>
> Thanks for the patch!
>
> On Wed, 22 Jul 2015 14:40:41 +0200, Guillaume GARDET wrote:
>> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>>
>> ---
>>   package/c-icap/c-icap.mk | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/package/c-icap/c-icap.mk b/package/c-icap/c-icap.mk
>> index 0f42b6c..00a250b 100644
>> --- a/package/c-icap/c-icap.mk
>> +++ b/package/c-icap/c-icap.mk
>> @@ -57,6 +57,8 @@ define C_ICAP_TUNE_INSTALLATION
>>   		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
>>   	$(SED) 's%INCDIR2=.*%INCDIR2=$(STAGING_DIR)/usr/include/c_icap%' \
>>   		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
>> +	$(SED) 's%LIBS="-L%LIBS="-L$(STAGING_DIR)%' \
>> +		$(STAGING_DIR)/usr/bin/c-icap-libicapapi-config
> Ah, right, I missed this one! However, I think it's useless to keep
> this -L option, this $(STAGING_DIR)/usr/lib is already in the library
> search path for the cross-compiler.
>
> What about just:
>
> 	$(SED) 's%-L$LIBDIR %%' $(STAGING_DIR)/usr/bin/c-icap-libicapapi-config

Ok, but $ sign must be escaped with another $:
         $(SED) 's%-L$$LIBDIR %%' $(STAGING_DIR)/usr/bin/c-icap-libicapapi-config

Do you want a I send a V2 with this solution?


Guillaume

>
> Thanks,
>
> Thomas

  reply	other threads:[~2015-07-22 13:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 12:40 [Buildroot] [PATCH] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build Guillaume GARDET
2015-07-22 12:55 ` Thomas Petazzoni
2015-07-22 13:30   ` Guillaume GARDET - Oliséo [this message]
2015-07-22 13:51     ` Thomas Petazzoni
2015-07-23  8:45       ` [Buildroot] [PATCH V2] " Guillaume GARDET
2015-07-23 21:11         ` Thomas Petazzoni
2015-07-24 14:04           ` Guillaume GARDET - Oliséo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AF9B0E.8080803@oliseo.fr \
    --to=guillaume.gardet@oliseo.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.