From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 4/4] drm/i915: Support for pread/pwrite from/to non shmem backed objects Date: Wed, 22 Jul 2015 16:46:00 +0100 Message-ID: <55AFBAB8.8050900@linux.intel.com> References: <1437573109-19211-1-git-send-email-ankitprasad.r.sharma@intel.com> <1437573109-19211-5-git-send-email-ankitprasad.r.sharma@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 912056EB16 for ; Wed, 22 Jul 2015 08:46:03 -0700 (PDT) In-Reply-To: <1437573109-19211-5-git-send-email-ankitprasad.r.sharma@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ankitprasad.r.sharma@intel.com, intel-gfx@lists.freedesktop.org Cc: akash.goel@intel.com, shashidhar.hiremath@intel.com List-Id: intel-gfx@lists.freedesktop.org CkhpLAoKT24gMDcvMjIvMjAxNSAwMjo1MSBQTSwgYW5raXRwcmFzYWQuci5zaGFybWFAaW50ZWwu Y29tIHdyb3RlOgo+IEZyb206IEFua2l0cHJhc2FkIFNoYXJtYSA8YW5raXRwcmFzYWQuci5zaGFy bWFAaW50ZWwuY29tPgo+Cj4gVGhpcyBwYXRjaCBhZGRzIHN1cHBvcnQgZm9yIGV4dGVuZGluZyB0 aGUgcHJlYWQvcHdyaXRlIGZ1bmN0aW9uYWxpdHkKPiBmb3Igb2JqZWN0cyBub3QgYmFja2VkIGJ5 IHNobWVtLiBUaGUgYWNjZXNzIHdpbGwgYmUgbWFkZSB0aHJvdWdoCj4gZ3R0IGludGVyZmFjZS4K PiBUaGlzIHdpbGwgY292ZXIgcHJpbWUgb2JqZWN0cyBhcyB3ZWxsIGFzIHN0b2xlbiBtZW1vcnkg YmFja2VkIG9iamVjdHMKPiBidXQgZm9yIHVzZXJwdHIgb2JqZWN0cyBpdCBpcyBzdGlsbCBmb3Ji aWRkZW4uCj4KPiB2MjogRHJvcCBsb2NrcyBhcm91bmQgc2xvd191c2VyX2FjY2VzcywgcHJlZmF1 bHQgdGhlIHBhZ2VzIGJlZm9yZQo+IGFjY2VzcyAoQ2hyaXMpCj4KPiB2MzogUmViYXNlZCB0byB0 aGUgbGF0ZXN0IGRybS1pbnRlbC1uaWdodGx5IChBbmtpdCkKPgo+IHY0OiBNb3ZlZCBwYWdlIGJh c2UgJiBvZmZzZXQgY2FsY3VsYXRpb25zIG91dHNpZGUgdGhlIGNvcHkgbG9vcCwKPiBjb3JyZWN0 ZWQgZGF0YSB0eXBlcyBmb3Igc2l6ZSBhbmQgb2Zmc2V0IHZhcmlhYmxlcywgY29ycmVjdGVkIGlm LWVsc2UKPiBicmFjZXMgZm9ybWF0IChUdnJ0a28va2VybmVsZG9jcykKPgo+IFRlc3RjYXNlOiBp Z3QvZ2VtX3N0b2xlbgo+Cj4gU2lnbmVkLW9mZi1ieTogQW5raXRwcmFzYWQgU2hhcm1hIDxhbmtp dHByYXNhZC5yLnNoYXJtYUBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbS5jIHwgMTM4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0t LS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMjEgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCA5ZTdlMTgyLi40MzIxMTc4IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTYzMSw2ICs2MzEsMTAyIEBAIHNobWVtX3By ZWFkX3Nsb3coc3RydWN0IHBhZ2UgKnBhZ2UsIGludCBzaG1lbV9wYWdlX29mZnNldCwgaW50IHBh Z2VfbGVuZ3RoLAo+ICAgCXJldHVybiByZXQgPyAtIEVGQVVMVCA6IDA7Cj4gICB9Cj4KPiArc3Rh dGljIGlubGluZSB1aW50NjRfdAo+ICtzbG93X3VzZXJfYWNjZXNzKHN0cnVjdCBpb19tYXBwaW5n ICptYXBwaW5nLAo+ICsJCSB1aW50NjRfdCBwYWdlX2Jhc2UsIGludCBwYWdlX29mZnNldCwKPiAr CQkgY2hhciBfX3VzZXIgKnVzZXJfZGF0YSwKPiArCQkgaW50IGxlbmd0aCwgYm9vbCBwd3JpdGUp Cj4gK3sKPiArCXZvaWQgX19pb21lbSAqdmFkZHJfaW5hdG9taWM7Cj4gKwl2b2lkICp2YWRkcjsK PiArCXVpbnQ2NF90IHVud3JpdHRlbjsKPiArCj4gKwl2YWRkcl9pbmF0b21pYyA9IGlvX21hcHBp bmdfbWFwX3djKG1hcHBpbmcsIHBhZ2VfYmFzZSk7Cj4gKwkvKiBXZSBjYW4gdXNlIHRoZSBjcHUg bWVtIGNvcHkgZnVuY3Rpb24gYmVjYXVzZSB0aGlzIGlzIFg4Ni4gKi8KPiArCXZhZGRyID0gKHZv aWQgX19mb3JjZSAqKXZhZGRyX2luYXRvbWljICsgcGFnZV9vZmZzZXQ7Cj4gKwlpZiAocHdyaXRl KQo+ICsJCXVud3JpdHRlbiA9IF9fY29weV9mcm9tX3VzZXIodmFkZHIsIHVzZXJfZGF0YSwgbGVu Z3RoKTsKPiArCWVsc2UKPiArCQl1bndyaXR0ZW4gPSBfX2NvcHlfdG9fdXNlcih1c2VyX2RhdGEs IHZhZGRyLCBsZW5ndGgpOwo+ICsKPiArCWlvX21hcHBpbmdfdW5tYXAodmFkZHJfaW5hdG9taWMp Owo+ICsJcmV0dXJuIHVud3JpdHRlbjsKPiArfQo+ICsKPiArc3RhdGljIGludAo+ICtpOTE1X2dl bV9ndHRfcHJlYWRfcHdyaXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCSAgc3RydWN0 IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgdWludDY0X3Qgc2l6ZSwKPiArCQkJICB1aW50NjRf dCBkYXRhX29mZnNldCwgdWludDY0X3QgZGF0YV9wdHIsIGJvb2wgcHdyaXRlKQo+ICt7Cj4gKwlz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICsJ Y2hhciBfX3VzZXIgKnVzZXJfZGF0YTsKPiArCXVpbnQ2NF90IHJlbWFpbjsKPiArCXVpbnQ2NF90 IG9mZnNldCwgcGFnZV9iYXNlOwo+ICsJaW50IHBhZ2Vfb2Zmc2V0LCBwYWdlX2xlbmd0aCwgcmV0 ID0gMDsKPiArCj4gKwlyZXQgPSBpOTE1X2dlbV9vYmpfZ2d0dF9waW4ob2JqLCAwLCBQSU5fTUFQ UEFCTEUpOwo+ICsJaWYgKHJldCkKPiArCQlnb3RvIG91dDsKPiArCj4gKwlyZXQgPSBpOTE1X2dl bV9vYmplY3Rfc2V0X3RvX2d0dF9kb21haW4ob2JqLCBwd3JpdGUpOwo+ICsJaWYgKHJldCkKPiAr CQlnb3RvIG91dF91bnBpbjsKPiArCj4gKwlyZXQgPSBpOTE1X2dlbV9vYmplY3RfcHV0X2ZlbmNl KG9iaik7Cj4gKwlpZiAocmV0KQo+ICsJCWdvdG8gb3V0X3VucGluOwo+ICsKPiArCXVzZXJfZGF0 YSA9IHRvX3VzZXJfcHRyKGRhdGFfcHRyKTsKPiArCXJlbWFpbiA9IHNpemU7Cj4gKwlvZmZzZXQg PSBpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQob2JqKSArIGRhdGFfb2Zmc2V0Owo+ICsKPiArCWlm IChwd3JpdGUpCj4gKwkJaW50ZWxfZmJfb2JqX2ludmFsaWRhdGUob2JqLCBPUklHSU5fR1RUKTsK PiArCj4gKwltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCWlmICghcHdyaXRl ICYmIGxpa2VseSghaTkxNS5wcmVmYXVsdF9kaXNhYmxlKSkKPiArCQlyZXQgPSBmYXVsdF9pbl9t dWx0aXBhZ2VzX3dyaXRlYWJsZSh1c2VyX2RhdGEsIHJlbWFpbik7Cj4gKwo+ICsJLyoKPiArCSAq IHBhZ2Vfb2Zmc2V0ID0gb2Zmc2V0IHdpdGhpbiBwYWdlCj4gKwkgKiBwYWdlX2Jhc2UgPSBwYWdl IG9mZnNldCB3aXRoaW4gYXBlcnR1cmUKPiArCSAqLwo+ICsJcGFnZV9vZmZzZXQgPSBvZmZzZXRf aW5fcGFnZShvZmZzZXQpOwo+ICsJcGFnZV9iYXNlID0gb2Zmc2V0ICYgUEFHRV9NQVNLOwo+ICsK PiArCXdoaWxlIChyZW1haW4gPiAwKSB7Cj4gKwkJLyogcGFnZV9sZW5ndGggPSBieXRlcyB0byBj b3B5IGZvciB0aGlzIHBhZ2UgKi8KPiArCQlwYWdlX2xlbmd0aCA9IHJlbWFpbjsKPiArCQlpZiAo KHBhZ2Vfb2Zmc2V0ICsgcmVtYWluKSA+IFBBR0VfU0laRSkKPiArCQkJcGFnZV9sZW5ndGggPSBQ QUdFX1NJWkUgLSBwYWdlX29mZnNldDsKPiArCj4gKwkJLyogVGhpcyBpcyBhIHNsb3cgcmVhZC93 cml0ZSBhcyBpdCB0cmllcyB0byByZWFkIGZyb20KPiArCQkgKiBhbmQgd3JpdGUgdG8gdXNlciBt ZW1vcnkgd2hpY2ggbWF5IHJlc3VsdCBpbnRvIHBhZ2UKPiArCQkgKiBmYXVsdHMKPiArCQkgKi8K PiArCQlyZXQgPSBzbG93X3VzZXJfYWNjZXNzKGRldl9wcml2LT5ndHQubWFwcGFibGUsIHBhZ2Vf YmFzZSwKPiArCQkJCSAgICAgICBwYWdlX29mZnNldCwgdXNlcl9kYXRhLAo+ICsJCQkJICAgICAg IHBhZ2VfbGVuZ3RoLCBwd3JpdGUpOwo+ICsKPiArCQlpZiAocmV0KSB7Cj4gKwkJCXJldCA9IC1F RkFVTFQ7Cj4gKwkJCWJyZWFrOwo+ICsJCX0KPiArCj4gKwkJcmVtYWluIC09IHBhZ2VfbGVuZ3Ro Owo+ICsJCXVzZXJfZGF0YSArPSBwYWdlX2xlbmd0aDsKPiArCQlwYWdlX2Jhc2UgKz0gcGFnZV9s ZW5ndGg7Cj4gKwkJcGFnZV9vZmZzZXQgPSAwOwo+ICsJfQo+ICsKPiArCW11dGV4X2xvY2soJmRl di0+c3RydWN0X211dGV4KTsKCk15IG9iamVjdGlvbiBoZXJlIHdhcyB0aGF0IHdlIGFyZSByZS1h Y3F1aXJpbmcgdGhlIG11dGV4IGluIApub24taW50ZXJydXB0aWJsZSBtb2RlLCB3aGlsZSB0aGUg Y2FsbGVyIGhhZCBpdCBpbnRlcnJ1cHRpYmxlLiBJdCBhbSBub3QgCjEwMCUgd2hhdCB0aGUgY29u Y2x1c2lvbiBiYWNrIHRoZW4gd2FzPwoKQnV0IGFsc28sIHdoeSBpdCBpcyBldmVuIG5lY2Vzc2Fy eSB0byBkcm9wIHRoZSBtdXRleCBoZXJlPwoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=