From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v5 7/7] x86/PCI: intercept all PV Dom0 MMCFG writes Date: Wed, 22 Jul 2015 18:55:03 +0100 Message-ID: <55AFD8F7.20402@citrix.com> References: <55AD1E830200007800093243@mail.emea.novell.com> <55AD208802000078000932C1@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHyEY-0006uX-Ag for xen-devel@lists.xenproject.org; Wed, 22 Jul 2015 17:55:10 +0000 In-Reply-To: <55AD208802000078000932C1@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org On 20/07/15 15:23, Jan Beulich wrote: > ... to hook up pci_conf_write_intercept() even for Dom0 not using > method 1 accesses for the base part of PCI device config space. > > Signed-off-by: Jan Beulich > --- > Not entirely sure whether the complicated logging logic in x86/mm.c is > actually worth it. There is a behavioural change insofar that 64bit access will no longer function, but I am not sure this matters too much, as such an access to config space is almost certainly buggy. The rest however looks sane, so Reviewed-by: Andrew Cooper