From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=//W78a3KkgGv+qICih+gOFE5BrJDgnz4gUqJYH2Ufko=; b=hnC6y5P/RWpZ9BSTw6CqEam4VGaXgMhLbO/qO37pTjTpUsUOgF24SLFuGs6M35Rg9j 9k8Dh+cp1ZtnYm945YKrFlvqPehcI/6Uz5kjT+7NQrC2bMpg9nN8gzE0NAa8x7VP+Rge JjSj0oyTyK0BcVIqjzHKqshrL/Wa7kpGj4ogg= References: <1437560929-25827-1-git-send-email-nikolay@cumulusnetworks.com> From: Nikolay Aleksandrov Message-ID: <55AFDA89.1080304@cumulusnetworks.com> Date: Wed, 22 Jul 2015 20:01:45 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next] bridge: mcast: when multicast is disabled flush the groups List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cong Wang Cc: netdev , "bridge@lists.linux-foundation.org" , David Miller On 07/22/2015 07:03 PM, Cong Wang wrote: > On Wed, Jul 22, 2015 at 3:28 AM, Nikolay Aleksandrov > wrote: >> From: Satish Ashok >> >> Once multicast gets disabled we should flush the groups. >> Example: >> # bridge mdb add dev br0 port eth3 grp 239.0.0.1 >> # bridge mdb >> dev br0 port eth3 grp 239.0.0.1 temp >> # echo 0 > multicast_snooping >> # bridge mdb > > Why? Why we can't save the mdb config for a mcast snooping flip? > Right, I've discussed this with my colleagues and we think this doesn't have any value for upstream and shouldn't have been sent which is bad judgment on my side. It actually makes things worse because it removes the user's permanent entries on snooping disable and it may happen automatically by hash exhaustion. Anyway, please drop this patch and sorry for the noise, I should've given this change more thought. Thanks, Nik From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next] bridge: mcast: when multicast is disabled flush the groups Date: Wed, 22 Jul 2015 20:01:45 +0200 Message-ID: <55AFDA89.1080304@cumulusnetworks.com> References: <1437560929-25827-1-git-send-email-nikolay@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev , "bridge@lists.linux-foundation.org" , David Miller To: Cong Wang Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 07/22/2015 07:03 PM, Cong Wang wrote: > On Wed, Jul 22, 2015 at 3:28 AM, Nikolay Aleksandrov > wrote: >> From: Satish Ashok >> >> Once multicast gets disabled we should flush the groups. >> Example: >> # bridge mdb add dev br0 port eth3 grp 239.0.0.1 >> # bridge mdb >> dev br0 port eth3 grp 239.0.0.1 temp >> # echo 0 > multicast_snooping >> # bridge mdb > > Why? Why we can't save the mdb config for a mcast snooping flip? > Right, I've discussed this with my colleagues and we think this doesn't have any value for upstream and shouldn't have been sent which is bad judgment on my side. It actually makes things worse because it removes the user's permanent entries on snooping disable and it may happen automatically by hash exhaustion. Anyway, please drop this patch and sorry for the noise, I should've given this change more thought. Thanks, Nik