All of lore.kernel.org
 help / color / mirror / Atom feed
From: roopa <roopa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] af_mpls: fix undefined reference to ip6_route_output
Date: Wed, 22 Jul 2015 13:22:09 -0700	[thread overview]
Message-ID: <55AFFB71.5040307@cumulusnetworks.com> (raw)
In-Reply-To: <20150722.130444.1245167673786115378.davem@davemloft.net>

On 7/22/15, 1:04 PM, David Miller wrote:
> From: Thomas Graf <tgraf@suug.ch>
> Date: Wed, 22 Jul 2015 21:57:06 +0200
>
>> On 07/22/15 at 12:30pm, roopa wrote:
>>> diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
>>> index 5c467ef..2b28615 100644
>>> --- a/net/mpls/Kconfig
>>> +++ b/net/mpls/Kconfig
>>> @@ -24,6 +24,8 @@ config NET_MPLS_GSO
>>>
>>>   config MPLS_ROUTING
>>>          tristate "MPLS: routing support"
>>> +       depends on INET
>>> +       depends on IPV6
>>>          ---help---
>>>           Add support for forwarding of mpls packets.
>> This looks like a much better fix to me and resolves the
>> module/built-in dependency mess.
> It's only OK if we don't create a new hard dependency on IPV6,
> which this patch does.
>
> Consitently across the tree we give the user the option of
> using a bi-AF facility with or without IPV6.
yes, ack. I have been trying to avoid that ...also because
af_mpls does support a family AF_PACKET mode that should continue to 
work without CONFIG_INET and CONFIG_INET6
(Though I have not tried it).

  parent reply	other threads:[~2015-07-22 20:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22  7:10 [PATCH net-next] af_mpls: fix undefined reference to ip6_route_output Roopa Prabhu
2015-07-22 12:23 ` Thomas Graf
2015-07-22 17:49   ` David Miller
2015-07-22 19:30     ` roopa
2015-07-22 19:57       ` Thomas Graf
2015-07-22 20:04         ` David Miller
2015-07-22 20:17           ` Thomas Graf
2015-07-22 20:38             ` roopa
2015-07-23  7:09               ` David Miller
2015-07-23 13:44                 ` roopa
2015-07-27  0:20                   ` David Miller
2015-07-22 20:22           ` roopa [this message]
2015-07-22 20:03       ` David Miller
2015-07-22 19:30   ` roopa
  -- strict thread matches above, loose matches on Subject: below --
2015-07-22 23:10 Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AFFB71.5040307@cumulusnetworks.com \
    --to=roopa@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.