From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 3/3] KVM: x86: quirkily apply WB to all memory if cache is disabled Date: Thu, 23 Jul 2015 14:03:50 +0800 Message-ID: <55B083C6.503@linux.intel.com> References: <1436988356-4565-1-git-send-email-guangrong.xiao@linux.intel.com> <1436988356-4565-3-git-send-email-guangrong.xiao@linux.intel.com> <55B081F1.50406@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, bsd@redhat.com, lersek@redhat.com, jordan.l.justen@intel.com, edk2-devel@lists.sourceforge.net, Xiao Guangrong To: Paolo Bonzini Return-path: In-Reply-To: <55B081F1.50406@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/23/2015 01:56 PM, Paolo Bonzini wrote: > > > On 15/07/2015 21:25, Xiao Guangrong wrote: >> From: Xiao Guangrong >> >> Current firmware depends on WB to fast boot, please refer to >> https://lkml.org/lkml/2015/7/12/115 >> >> Let's us WB if CR0.CD is set to make this kind of firmware happy >> >> This quirk can be dropped by using KVM_ENABLE_CAP API with >> KVM_CAP_DISABLE_QUIRKS if the broken firmware is gone >> >> Signed-off-by: Xiao Guangrong > > Your patch is actually *enabling* the quirk if KVM_QUIRK_CD_AS_WB is > included in the disabled quirks. I'm squashing in this change: Yep, i misunderstood the meaning of "disabled-quirks", thanks for your nice adjustment, Paolo!