From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is completely
 disabled
Date: Thu, 23 Jul 2015 14:29:24 +0800
Message-ID: <55B089C4.5000200@linux.intel.com>
References: <1436988356-4565-1-git-send-email-guangrong.xiao@linux.intel.com> <1437019818.1391.544.camel@redhat.com> <55B087D4.80106@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, bsd@redhat.com, lersek@redhat.com,
	jordan.l.justen@intel.com, edk2-devel@lists.sourceforge.net,
	Xiao Guangrong <guangrong.xiao@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga03.intel.com ([134.134.136.65]:46537 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750859AbbGWGel (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 23 Jul 2015 02:34:41 -0400
In-Reply-To: <55B087D4.80106@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 07/23/2015 02:21 PM, Paolo Bonzini wrote:
>
>
> On 16/07/2015 06:10, Alex Williamson wrote:
>> On Thu, 2015-07-16 at 03:25 +0800, Xiao Guangrong wrote:
>>>> From: Xiao Guangrong <guangrong.xiao@intel.com>
>>>>
>>>> Currently code uses default memory type if MTRR is fully disabled,
>>>> fix it by using UC instead
>>>>
>>>> Signed-off-by: Xiao Guangrong <guangrong.xiao@intel.com>
>>>> ---
>> Seems to work for me.  I don't see a 0th patch, but for the series:
>>
>> Tested-by: Alex Williamson <alex.williamson@redhat.com>
>
> In fact this is the same quirk already implemented for SVM as
> KVM_QUIRK_CD_NW_CLEARED, so we can reuse the bit.

Sounds good to me. I will drop the new bit and reuse as your suggestion.
And i think we need document this whole staff in API.txt ...