From: Daniel Borkmann <daniel@iogearbox.net>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>, shemminger@vyatta.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 iproute2] tc: fix bpf compilation with old glibc
Date: Thu, 23 Jul 2015 09:25:13 +0200 [thread overview]
Message-ID: <55B096D9.2050806@iogearbox.net> (raw)
In-Reply-To: <1437635861-19157-1-git-send-email-nicolas.dichtel@6wind.com>
On 07/23/2015 09:17 AM, Nicolas Dichtel wrote:
> Error was:
> f_bpf.o: In function `bpf_parse_opt':
> f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv'
> m_bpf.o: In function `parse_bpf':
> m_bpf.c:(.text+0x587): undefined reference to `secure_getenv'
> collect2: error: ld returned 1 exit status
>
> There is no special reason to use the secure version of getenv, thus let's
> simply use getenv().
>
> CC: Daniel Borkmann <daniel@iogearbox.net>
> Fixes: 88eea5395483 ("tc: {f,m}_bpf: allow to retrieve uds path from env")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2015-07-23 7:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 12:29 [PATCH iproute2] tc: fix bpf compilation with old glibc Nicolas Dichtel
2015-07-22 13:05 ` Daniel Borkmann
2015-07-22 13:18 ` Nicolas Dichtel
[not found] ` <19c76849dd1f4a94875b0aa5d3d7e96c@HQ1WP-EXMB12.corp.brocade.com>
2015-07-22 16:47 ` Stephen Hemminger
2015-07-23 7:17 ` [PATCH v2 " Nicolas Dichtel
2015-07-23 7:25 ` Daniel Borkmann [this message]
2015-07-23 21:50 ` Alexei Starovoitov
2015-07-27 8:09 ` Yegor Yefremov
2015-07-27 21:36 ` [PATCH " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B096D9.2050806@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.