From: Jan Kiszka <jan.kiszka@siemens.com>
To: Philippe Gerum <rpm@xenomai.org>
Cc: Xenomai <xenomai@xenomai.org>
Subject: Re: [Xenomai] Xenomai 3: comapt issues with RTDM
Date: Thu, 23 Jul 2015 11:08:14 +0200 [thread overview]
Message-ID: <55B0AEFE.5080202@siemens.com> (raw)
In-Reply-To: <55B0A89B.5020004@xenomai.org>
On 2015-07-23 10:40, Philippe Gerum wrote:
> On 07/21/2015 04:54 PM, Jan Kiszka wrote:
>> On 2015-07-21 14:51, Philippe Gerum wrote:
>>> On 07/21/2015 02:27 PM, Jan Kiszka wrote:
>>>> Hi Philippe,
>>>>
>>>> just a heads up, I'll try to address this later:
>>>>
>>>> I received a report that include/rtdm/uapi/rtdm.h contains some data
>>>> structures that are used between the kernel and the userspace library
>>>> (so not directly by applications) and are not compatible with
>>>> 32-on-64-bit (compat) scenarios. We should probably promote anything
>>>> that is longer on 64-bit to that size, unconditionally. As this affects
>>>> the ABI, it should be fixed before 3.0 release, ideally.
>>>>
>>>
>>> That would require to fix up the client drivers (setsockopt, getsockopt
>>> typically). Ok, I'll have a look when I'm done with testing the blackfin
>>> port.
>>
>> Indeed. Just realized that there are already compat structs for the
>> socket stuff. However, and that was what our user stumbled over, there
>> is none for _rtdm_mmap_request. But that should be really internal, right?
>>
>
> mmap() has the compat thunk for 32<->64 bit conversion already, so this
> is ok.
Ok... Rechecking the bug report here, the issue is rather the case that
off_t becomes 64 bit when defining -D_FILE_OFFSET_BITS=64 for your
userland. We are apparently required to account for that case as well.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2015-07-23 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 12:27 [Xenomai] Xenomai 3: comapt issues with RTDM Jan Kiszka
2015-07-21 12:51 ` Philippe Gerum
2015-07-21 14:54 ` Jan Kiszka
2015-07-21 15:41 ` Philippe Gerum
2015-07-23 8:40 ` Philippe Gerum
2015-07-23 9:08 ` Jan Kiszka [this message]
2015-07-23 9:22 ` Philippe Gerum
2015-07-23 13:37 ` Jan Kiszka
2015-07-23 19:45 ` Philippe Gerum
2015-07-24 7:24 ` Philippe Gerum
2015-07-24 10:02 ` Philippe Gerum
2015-07-24 12:17 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0AEFE.5080202@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=rpm@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.