From: stefan.wahren@i2se.com (Stefan Wahren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: i.MX35: Fix can support.
Date: Thu, 23 Jul 2015 11:48:45 +0200 [thread overview]
Message-ID: <55B0B87D.5070800@i2se.com> (raw)
In-Reply-To: <55B0B3E8.20900@pengutronix.de>
Am 23.07.2015 um 11:29 schrieb Marc Kleine-Budde:
> On 07/23/2015 10:58 AM, Stefan Wahren wrote:
>> Hi Denis,
>>
>> [ add Marc to CC ]
>>
>> Am 23.07.2015 um 10:31 schrieb Denis Carikli:
>>> Since commit 3d42a379b6fa5b46058e3302b1802b29f64865bb
>>> ("can: flexcan: add 2nd clock to support imx53 and newer")
>>> the can driver requires a dt nodes to have a second clock.
>>> Add them to imx35 to fix probing the flex can driver on the
>>> respective platforms.
>> could you describe the problem more in detail or do you have a log in
>> case the probing failed?
>>
>> According to Marc's commit this fix shouldn't be necessary.
> In the pre DT era and without a clock name, a single clock is
> sufficient. But with clock name or DT with clock-name you need both a
> "ipg" and a "per" clock. The imx35.dtsi was added with one clock only,
> so it was probably never working on mx35 with DT.
Okay the other plaforms like mx25 and mx28 already had 2 clocks defined.
But why doesn't say the binding doc nothing about those required clocks?
Stefan
>
> Marc
>
next prev parent reply other threads:[~2015-07-23 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 15:01 [PATCH] ARM: dts: i.MX35: Fix can support Denis Carikli
2015-07-22 18:04 ` Uwe Kleine-König
2015-07-23 8:31 ` [PATCH v2] " Denis Carikli
2015-07-23 8:58 ` Stefan Wahren
2015-07-23 9:29 ` Marc Kleine-Budde
2015-07-23 9:48 ` Stefan Wahren [this message]
2015-07-23 9:54 ` Marc Kleine-Budde
2015-07-25 3:38 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0B87D.5070800@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.