From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIEOF-0003uK-EV for qemu-devel@nongnu.org; Thu, 23 Jul 2015 07:10:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIEOB-0000eD-Hq for qemu-devel@nongnu.org; Thu, 23 Jul 2015 07:10:15 -0400 References: <1437649738-13885-1-git-send-email-peter.maydell@linaro.org> From: Paolo Bonzini Message-ID: <55B0CB85.6020903@redhat.com> Date: Thu, 23 Jul 2015 13:09:57 +0200 MIME-Version: 1.0 In-Reply-To: <1437649738-13885-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Keith Busch , Kevin Wolf , "Michael S. Tsirkin" , qemu-block@nongnu.org, patches@linaro.org On 23/07/2015 13:08, Peter Maydell wrote: > We have a qemu_fls() function which is just a silly wrapper > around clz32() and which is used in only a handful of places > in the codebase. It turns out that all of those are really > trying to round up or down to a power of 2, which is something > we have utility functions for. This series replaces all > the qemu_fls() calls with pow2ceil() or pow2floor(), and then > removes the now-unused function. > > For the case where you really want to do bit counting rather > than just power-of-2 rounding, you should use the clz/clo > functions directly. > > (I've set myself a little goal of "try to do one cleanup a > day"; that may be a bit ambitious, so we'll see...) If it turns out to be ambitious, even just "record one cleanup a day in BiteSizedTasks" would be awesome. Paolo