From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined
Date: Thu, 23 Jul 2015 12:51:55 +0100 [thread overview]
Message-ID: <55B0D55B.6010200@citrix.com> (raw)
In-Reply-To: <55AFC6E902000078000941D2@prv-mh.provo.novell.com>
On 22/07/15 15:38, Jan Beulich wrote:
> This being an in-guest component, it shouldn't get to see (and even
> less so use) tools-only public interfaces.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/tools/firmware/hvmloader/Makefile
> +++ b/tools/firmware/hvmloader/Makefile
> @@ -31,6 +31,9 @@ SMBIOS_REL_DATE ?= $(shell date +%m/%d/%
>
> CFLAGS += $(CFLAGS_xeninclude)
>
> +# We mustn't use tools-only public interfaces.
> +CFLAGS += -U__XEN_TOOLS__ -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
> +
> OBJS = hvmloader.o mp_tables.o util.o smbios.o
> OBJS += smp.o cacheattr.o xenbus.o vnuma.o
> OBJS += e820.o pci.o pir.o ctype.o
>
>
>
prev parent reply other threads:[~2015-07-23 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 14:38 [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined Jan Beulich
2015-07-23 8:10 ` Ian Campbell
2015-07-23 11:51 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0D55B.6010200@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.