From: Tim Gardner <tim.gardner@canonical.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure
Date: Thu, 23 Jul 2015 06:12:50 -0600 [thread overview]
Message-ID: <55B0DA42.2050704@canonical.com> (raw)
In-Reply-To: <20150723101844.9D3F0140D19@ozlabs.org>
On 07/23/2015 04:18 AM, Michael Ellerman wrote:
> On Mon, 2015-20-07 at 19:01:42 UTC, Tim Gardner wrote:
>> From: Tim Gardner <tim.gardner@canonical.com>
>>
>> drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class
>> module_init(anslcd_init);
>> ^
>> drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
>>
>> gcc version 4.9.3 (Ubuntu 4.9.3-1ubuntu1)
>
> Thanks Tim but Luis beat you to it:
>
> http://patchwork.ozlabs.org/patch/497138/
>
>
> I'll send the fix to Linus in the next day or two.
>
> cheers
>
No problem. It looks like a better fix then mine anyway.
rtg
--
Tim Gardner tim.gardner@canonical.com
prev parent reply other threads:[~2015-07-23 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 19:01 [PATCH 4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure tim.gardner
2015-07-23 10:18 ` [4.2-rc3] " Michael Ellerman
2015-07-23 12:12 ` Tim Gardner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0DA42.2050704@canonical.com \
--to=tim.gardner@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.