All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Congyang <ghostwcy@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] rcu: actually register threads that have RCU read-side critical sections
Date: Thu, 23 Jul 2015 20:59:14 +0800	[thread overview]
Message-ID: <55B0E522.1000009@gmail.com> (raw)
In-Reply-To: <55B0CB47.2070301@redhat.com>

At 2015/7/23 19:08, Paolo Bonzini Wrote:
>
>
> On 23/07/2015 13:04, Wen Congyang wrote:
>>> Yes.  I think this is better for 2.4.  There are threads that do not
>>> need RCU, for example the thread-pool.c worker threads, so it may just
>>
>> If the thread doesn't use RCU, rcu_register_thread() is harmless, is it right?
>
> Every rcu_register_thread() makes synchronize_rcu() a little slower.

Yes, but synchronize_rcu() is very slow...

>
>>>> be simpler to add an assertion in rcu_register_thread.  I'm just a bit
>>>> wary of doing little more than the bare minimum in 2.4, because of the
>>>> OS X failure that I didn't quite understand.
>> Which problem? I don't find it in the maillist.
>
> http://article.gmane.org/gmane.comp.emulators.qemu/351548

Hmm, I guess rcu_reader is invalid when pthread key is destroyed. 
pthread key and __thread
variable, which is destroyed first? I don't find any document to 
describe it.

Thanks
Wen Congyang

>
> Paolo
>
>

  reply	other threads:[~2015-07-23 12:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 14:18 [Qemu-devel] [PATCH] rcu: actually register threads that have RCU read-side critical sections Paolo Bonzini
2015-07-23  2:56 ` Wen Congyang
2015-07-23  5:35   ` Paolo Bonzini
2015-07-23 10:30 ` Christian Borntraeger
2015-07-23 10:42   ` Paolo Bonzini
2015-07-23 11:04     ` Wen Congyang
2015-07-23 11:08       ` Paolo Bonzini
2015-07-23 12:59         ` Wen Congyang [this message]
2015-07-23 16:58           ` Paolo Bonzini
2015-07-24  3:55             ` Wen Congyang
2015-07-24  5:56             ` Wen Congyang
2015-07-24  6:22               ` Paolo Bonzini
2015-07-24  6:30                 ` Wen Congyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B0E522.1000009@gmail.com \
    --to=ghostwcy@gmail.com \
    --cc=borntraeger@de.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wency@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.