From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH] xen: arm: Document xenheap_megabytes
	limitation
Date: Thu, 23 Jul 2015 17:49:33 +0100
Message-ID: <55B11B1D.1070608@citrix.com>
References: <4EE5B48738DDED408878C97C8E050A8B1D7D96EB@SJEXCHMB05.corp.ad.broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4EE5B48738DDED408878C97C8E050A8B1D7D96EB@SJEXCHMB05.corp.ad.broadcom.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Chris (Christopher) Brand" <chris.brand@broadcom.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

Hi Chris,

Thank you for patch.

On 23/07/15 17:31, Chris (Christopher) Brand wrote:
> In setup_mm(), the value passed as xenheap_megabytes gets
> converted to pages and passed to setup_xenheap_mappings(),
> which in turn passes it to create_32mb_mappings(), which
> contains an ASSERT that the value passed is a multiple of
> 32MB. So specifying any value that is not an integer multiple
> of 32 will cause Xen to hit this assert and fail to boot.
> 
> Signed-off-by: Chris Brand <chris.brand@broadcom.com>

I wondering if it would worth to add a check in the code to ensure that
it's a multiple of 32MB?

Nonetheless:

Reviewed-by: Julien Grall <julien.grall@citrix.com>

> ---
>  docs/misc/xen-command-line.markdown | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown
> index 4889e27626d4..f3d3bd6ce56a 100644
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -242,7 +242,7 @@ the NMI watchdog is also enabled.
>  
>  > Default: `0` (1/32 of RAM)
>  
> -Amount of RAM to set aside for the Xenheap.
> +Amount of RAM to set aside for the Xenheap. Must be an integer multiple of 32.
>  
>  By default will use 1/32 of the RAM up to a maximum of 1GB and with a
>  minimum of 32M, subject to a suitably aligned and sized contiguous
> 


Regards,

-- 
Julien Grall