From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Henningsson Subject: Re: [PATCH v1] ALSA: hda- Add headset mic pin quirk for a Dell device Date: Fri, 24 Jul 2015 10:03:22 +0200 Message-ID: <55B1F14A.1080106@canonical.com> References: <1437713442-6061-1-git-send-email-woodrow.shen@canonical.com> <55B1E5FB.1080702@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by alsa0.perex.cz (Postfix) with ESMTP id 728EC26057F for ; Fri, 24 Jul 2015 10:03:22 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, woodrow.shen@canonical.com, 1475553@bugs.launchpad.net List-Id: alsa-devel@alsa-project.org On 2015-07-24 09:50, Takashi Iwai wrote: > On Fri, 24 Jul 2015 09:15:07 +0200, > David Henningsson wrote: >> >> >> >> On 2015-07-24 08:54, Takashi Iwai wrote: >>> On Fri, 24 Jul 2015 06:50:42 +0200, >>> woodrow.shen@canonical.com wrote: >>>> >>>> From: Woodrow Shen >>>> >>>> Fix the headset mic that will not work on Dell desktop machine. >>>> BugLink: https://bugs.launchpad.net/bugs/1475553 >>>> Signed-off-by: Woodrow Shen >>> >>> I have repeatedly received patches with the very same subject and with >>> the very similar content but without further explanation. It's too >>> confusing. >>> >>> Please look through the git commit history of this file, and re-read >>> your patch. Then, consider a more useful subject / description, and >>> resubmit the patch. >> >> Hi Takashi, >> >> We're doing enablement of machines and several of them need pin quirks >> in order to have the headset mic working. Since these machines are >> pre-release, we are not allowed to make the final name of the machine >> public (e g, "Dell XPS 13"). For the same reason, we cannot give you >> alsa-info either. >> >> Given this constraint, how do you suggest we improve the subject / >> description? Or should we wait to submit upstream until the machine has >> been released to the market? > > I don't mean to give alsa-info.sh output or such. The problem is that > it's always with the same subject and the same text. How do you know > it's for what and apply in which order? > > At least you should try the patch looks different with each other, > describe the relationship with previous commits, etc. Right, so merely change the semantics, like "One more headset quirk", "Yet another headset quirk", "a totally splendid headset quirk", "oh look it's a headset quirk", "a headset quirk for a sunny day", and so on? The relationship with previous commits is that they fix the same problem for different machines, so they're usually independent of each other. -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic