All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Jiri Kosina <jkosina@suse.com>
Cc: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	linux-input@vger.kernel.org, rpurdie@rpsys.net,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: LEDs - skip unnamed LEDs
Date: Fri, 24 Jul 2015 10:22:04 +0200	[thread overview]
Message-ID: <55B1F5AC.3080702@suse.cz> (raw)
In-Reply-To: <20150722220202.GG14875@dtor-ws>

On 07/23/2015 12:02 AM, Dmitry Torokhov wrote:
> Devices may declare more LEDs than what is known to input-leds
> (HID does this for some devices). Instead of showing ugly warnings
> on connect and, even worse, oopsing on disconnect, let's simply
> ignore LEDs that are not known to us.
>
> Reported-by: Vlastimil Babka <vbabka@suse.cz>

No more warnings and oopses, so:

Reported-and-tested-by: Vlastimil Babka <vbabka@suse.cz>

FTR, it now looks like this:
gusiac:/sys/bus/hid/devices/0003:046D:C50E.0004/input/input15 # ls -1 | 
grep input15
input15::charging
input15::mail
input15::misc

All three have max_brightness of 1, but echo 1 > brightness does 
nothing. Clearly the leds are indeed autonomous only and the mouse 
shouldn't even report them.

Thanks,
Vlastimil

  parent reply	other threads:[~2015-07-24  8:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 22:02 [PATCH] Input: LEDs - skip unnamed LEDs Dmitry Torokhov
2015-07-23  5:40 ` Vlastimil Babka
2015-07-23  6:19 ` Pavel Machek
2015-07-23 20:57   ` Dmitry Torokhov
2015-07-23 21:22     ` Pavel Machek
2015-07-23 21:36       ` Dmitry Torokhov
2015-07-24  8:22 ` Vlastimil Babka [this message]
2015-07-24  8:48   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B1F5AC.3080702@suse.cz \
    --to=vbabka@suse.cz \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkosina@suse.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.