From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39627)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZIYf9-0003hn-7c
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 04:49:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZIYf8-0004q6-8y
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 04:49:03 -0400
References: <1437649738-13885-1-git-send-email-peter.maydell@linaro.org>
	<55B11C5C.8050507@redhat.com>
	<CAFEAcA9bBaZWcphoHvN5qLeYSAF75380bJXGqUDUDBx53nV_Ew@mail.gmail.com>
	<55B1C8BF.7060806@redhat.com>
	<CAFEAcA-mSm9x-oe5mWi2aPyTcLQ_QvcccnoJytu4Kkx+=VMM=g@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55B1FBF3.3030501@redhat.com>
Date: Fri, 24 Jul 2015 10:48:51 +0200
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-mSm9x-oe5mWi2aPyTcLQ_QvcccnoJytu4Kkx+=VMM=g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/5] replace qemu_fls() with
	pow2ceil()/pow2floor()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Qemu-block <qemu-block@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>, Patch Tracking <patches@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Keith Busch <keith.busch@intel.com>



On 24/07/2015 10:39, Peter Maydell wrote:
>> > But in patch 4 the call is only in the rare case where "l & (l - 1)" is
>> > not zero.
> True. Any preferences for which header file to put them in?
> qemu-common.h is where the prototype is currently and where
> the inline is_power_of_2() is defined...

Either there, or host-utils.h.

Paolo