All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: William Towle <william.towle@codethink.co.uk>,
	linux-media@vger.kernel.org, linux-kernel@lists.codethink.co.uk
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 09/13] media: soc_camera: soc_scale_crop: Use correct pad number in try_fmt
Date: Fri, 24 Jul 2015 16:14:24 +0200	[thread overview]
Message-ID: <55B24840.5000508@xs4all.nl> (raw)
In-Reply-To: <1437654103-26409-10-git-send-email-william.towle@codethink.co.uk>

On 07/23/2015 02:21 PM, William Towle wrote:
> From: Rob Taylor <rob.taylor@codethink.co.uk>
> 
> Fix calls to subdev try_fmt function to use valid pad numbers, fixing
> the case where subdevs (eg. ADV7612) have valid pad numbers that are
> non-zero.
> 
> Signed-off-by: William Towle <william.towle@codethink.co.uk>
> Reviewed-by: Rob Taylor <rob.taylor@codethink.co.uk>

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

	Hans

> ---
>  drivers/media/platform/soc_camera/soc_scale_crop.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/soc_camera/soc_scale_crop.c b/drivers/media/platform/soc_camera/soc_scale_crop.c
> index bda29bc..2772215 100644
> --- a/drivers/media/platform/soc_camera/soc_scale_crop.c
> +++ b/drivers/media/platform/soc_camera/soc_scale_crop.c
> @@ -225,6 +225,7 @@ static int client_set_fmt(struct soc_camera_device *icd,
>  	bool host_1to1;
>  	int ret;
>  
> +	format->pad = icd->src_pad_idx;
>  	ret = v4l2_device_call_until_err(sd->v4l2_dev,
>  					 soc_camera_grp_id(icd), pad,
>  					 set_fmt, NULL, format);
> 


  reply	other threads:[~2015-07-24 14:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 12:21 HDMI and Composite capture on Lager, for kernel 4.1, version 5 William Towle
2015-07-23 12:21 ` [PATCH 01/13] ARM: shmobile: lager dts: Add entries for VIN HDMI input support William Towle
2015-07-23 12:21 ` [PATCH 02/13] ARM: shmobile: lager dts: specify default-input for ADV7612 William Towle
2015-07-23 12:21 ` [PATCH 03/13] media: adv7604: fix probe of ADV7611/7612 William Towle
2015-07-24 14:19   ` Hans Verkuil
2015-07-27 12:29     ` William Towle
2015-07-24 14:34   ` [Linux-kernel] " Ben Dooks
2015-07-23 12:21 ` [PATCH 04/13] media: adv7604: reduce support to first (digital) input William Towle
2015-07-24 14:12   ` Hans Verkuil
2015-07-23 12:21 ` [PATCH 05/13] v4l: subdev: Add pad config allocator and init William Towle
2015-07-24 14:12   ` Hans Verkuil
2015-08-11 13:03     ` Mauro Carvalho Chehab
2015-07-23 12:21 ` [PATCH 06/13] media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 input support William Towle
2015-07-23 12:21 ` [PATCH 07/13] media: soc_camera pad-aware driver initialisation William Towle
2015-07-24 14:18   ` Hans Verkuil
2015-07-27 12:35     ` William Towle
2017-10-27  8:52   ` Sergei Shtylyov
2017-10-27  8:56     ` Sergei Shtylyov
2015-07-23 12:21 ` [PATCH 08/13] media: rcar_vin: Use correct pad number in try_fmt William Towle
2015-07-24 14:14   ` Hans Verkuil
2015-07-23 12:21 ` [PATCH 09/13] media: soc_camera: soc_scale_crop: " William Towle
2015-07-24 14:14   ` Hans Verkuil [this message]
2015-07-23 12:21 ` [PATCH 10/13] media: soc_camera: Fill std field in enum_input William Towle
2015-07-23 12:21 ` [PATCH 11/13] media: soc_camera: Fix error reporting in expbuf William Towle
2015-07-23 12:21 ` [PATCH 12/13] media: rcar_vin: fill in bus_info field William Towle
2015-07-24 14:14   ` Hans Verkuil
2015-07-23 12:21 ` [PATCH 13/13] media: rcar_vin: Reject videobufs that are too small for current format William Towle
2015-07-28  8:03 ` HDMI and Composite capture on Lager, for kernel 4.1, version 5 Guennadi Liakhovetski
2015-07-28  9:20 ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B24840.5000508@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-media@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=william.towle@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.