From: Gionatan Danti <g.danti@assyoma.it>
To: Seunguk Shin <seunguk.shin@samsung.com>
Cc: linux-raid@vger.kernel.org, g.danti@assyoma.it
Subject: Re: [PATCH] raid0: data corruption when using trim
Date: Fri, 24 Jul 2015 16:42:19 +0200 [thread overview]
Message-ID: <55B24ECB.3080705@assyoma.it> (raw)
In-Reply-To: <023401d0c60a$fff39330$ffdab990$@samsung.com>
Hi Seunguk,
thank you for your further explanation.
Does it means that only driver with Queued TRIM are affected, or it
affect all TRIM-capable driver?
What I wounder is that, if it is only a timing-triggered problem, why it
is only apparent on specific SSDs? I would expect it to manifest on
other devices also, albeit with different frequency.
Sorry if some questions sound dumb, I'm only trying to understand.
Thanks.
On 24/07/15 14:19, Seunguk Shin wrote:
> Gionatan,
>
> Because it is related with timing.
>
> 1st trim is issued and before complete it, 2nd trim is started
> (allocates memory but is not issued to device)
> Then, when 1st trim is completed, it frees 2nd trim's memory,
> because they share the pointer due to bug.
> If 3rd trim is started before 2nd trim is issued to device,
> 3rd trim can allocate the same memory with 2nd trim,
> because it is freed when 1st trim is completed.
> Only this case makes the corruption.
>
> Thank you,
> Seunguk Shin
>
>>
>> Hi, any idea on why the bug affects/manifests only on specific SATA SSDs?
>> It is timing related, or it depends on how the controller manage TRIM
>> requests?
>>
>> Thanks.
>>
>> --
>> Danti Gionatan
>> Supporto Tecnico
>> Assyoma S.r.l. - www.assyoma.it
>> email: g.danti@assyoma.it - info@assyoma.it GPG public key ID: FF5F32A8
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
>> the body of a message to majordomo@vger.kernel.org More majordomo info at
>> http://vger.kernel.org/majordomo-info.html
>
--
Danti Gionatan
Supporto Tecnico
Assyoma S.r.l. - www.assyoma.it
email: g.danti@assyoma.it - info@assyoma.it
GPG public key ID: FF5F32A8
next prev parent reply other threads:[~2015-07-24 14:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 3:28 [PATCH] raid0: data corruption when using trim Seunguk Shin
2015-07-20 12:33 ` Martin K. Petersen
2015-07-20 17:38 ` Piergiorgio Sartor
2015-07-20 18:26 ` Martin K. Petersen
2015-07-20 18:34 ` Piergiorgio Sartor
2015-07-21 4:28 ` Martin K. Petersen
2015-07-23 16:46 ` Gionatan Danti
2015-07-23 22:17 ` Martin K. Petersen
2015-07-24 6:37 ` Gionatan Danti
2015-07-21 4:18 ` Seunguk Shin
2015-07-21 4:55 ` Martin K. Petersen
2015-07-22 11:21 ` Seunguk Shin
2015-07-22 11:59 ` Martin K. Petersen
2015-07-24 6:47 ` Gionatan Danti
[not found] ` <023401d0c60a$fff39330$ffdab990$@samsung.com>
2015-07-24 14:42 ` Gionatan Danti [this message]
2015-07-24 15:03 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B24ECB.3080705@assyoma.it \
--to=g.danti@assyoma.it \
--cc=linux-raid@vger.kernel.org \
--cc=seunguk.shin@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.