Re: [PATCH 02/17] checksum: Add l_checksum_clone API.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

Hi Andrew,

On 07/23/2015 10:26 PM, Andrew Zaborowski wrote:
> In the kernel API we use and also in GLib's API the l_checksum_get_digest()
> equivalents can only be called once on each object meaning that in a
> situation when multiple digest values at different points of a
> running stream are needed the API becomes impractical.  The new _clone()
> call returns a clone of the checksum's state at the current time, on
> which get_digest() can be called.
> ---
>   ell/checksum.c | 24 ++++++++++++++++++++++++
>   ell/checksum.h |  1 +
>   2 files changed, 25 insertions(+)
>

<snip>

> +LIB_EXPORT struct l_checksum *l_checksum_clone(struct l_checksum *checksum)
> +{
> +	struct l_checksum *clone;
> +

Patch has been applied, but I also added a tiny sanity check here to 
make sure that checksum != NULL in a follow-on commit.

Regards,
-Denis