From: "Horia Geantă" <horia.geanta@freescale.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Victoria Milhoan <vicki.milhoan@freescale.com>,
<herbert@gondor.apana.org.au>
Cc: <linux-crypto@vger.kernel.org>, <ruchika.gupta@freescale.com>
Subject: Re: [PATCH RFC 06/11] crypto: caam - Enable MXC devices to select CAAM driver in Kconfig
Date: Fri, 24 Jul 2015 20:14:31 +0300 [thread overview]
Message-ID: <55B27277.2010403@freescale.com> (raw)
In-Reply-To: <20150617072734.GK7947@pengutronix.de>
On 6/17/2015 10:27 AM, Steffen Trumtrar wrote:
> On Mon, Jun 15, 2015 at 04:52:54PM -0700, Victoria Milhoan wrote:
>> From: Steve Cornelius <steve.cornelius@freescale.com>
>>
>> Allow CAAM to be selected in the kernel for Freescale i.MX6 devices if
>> ARCH_MXC is enabled.
>>
>> Signed-off-by: Steve Cornelius <steve.cornelius@freescale.com>
>> Signed-off-by: Victoria Milhoan <vicki.milhoan@freescale.com>
>> ---
>> drivers/crypto/caam/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/crypto/caam/Kconfig b/drivers/crypto/caam/Kconfig
>> index e7555ff..bc9aa07 100644
>> --- a/drivers/crypto/caam/Kconfig
>> +++ b/drivers/crypto/caam/Kconfig
>> @@ -1,6 +1,6 @@
>> config CRYPTO_DEV_FSL_CAAM
>> tristate "Freescale CAAM-Multicore driver backend"
>> - depends on FSL_SOC
>> + depends on FSL_SOC || ARCH_MXC
>
> Is this right? Are there other i.MX that have the CAAM IP core?
> Sounds like it should be SOC_IMX6 instead.
Even more, not all SOC_IMX6 variants have a CAAM block.
Not sure what's better:
-try to exactly indicate the HW that has the IP
-only name the arch / SoC (provided compilation passes), and then depend
on defconfig and/or device tree (and possibly boot loader dynamically
fixing the DT)
For e.g. Sahara crypto driver also depends on ARCH_MXC and it's not
available on all i.MX SoCs.
Thanks,
Horia
next prev parent reply other threads:[~2015-07-24 17:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 23:52 [PATCH RFC 00/11] crypto: caam - Add i.MX6 support to the Freescale CAAM driver Victoria Milhoan
2015-06-15 23:52 ` [PATCH RFC 01/11] crypto: caam - Add cache coherency support Victoria Milhoan
2015-06-16 1:35 ` Herbert Xu
2015-06-16 2:33 ` Herbert Xu
2015-06-16 3:29 ` Herbert Xu
2015-06-17 8:23 ` Steffen Trumtrar
2015-06-15 23:52 ` [PATCH RFC 02/11] crypto: caam - Add register I/O primitives for ARM compatibility Victoria Milhoan
2015-06-15 23:52 ` [PATCH RFC 03/11] crypto: caam - Enable and disable clocks on Freescale i.MX platforms Victoria Milhoan
2015-06-16 4:30 ` Herbert Xu
2015-06-16 4:32 ` Herbert Xu
2015-06-15 23:52 ` [PATCH RFC 04/11] crypto: caam - Modify Freescale CAAM driver Scatter Gather entry definition Victoria Milhoan
2015-06-15 23:52 ` [PATCH RFC 05/11] crypto: caam - Add cache coherency support to Freescale CAAM scatterlist implementation Victoria Milhoan
2015-06-16 6:04 ` Herbert Xu
2015-06-17 7:44 ` Steffen Trumtrar
2015-06-15 23:52 ` [PATCH RFC 06/11] crypto: caam - Enable MXC devices to select CAAM driver in Kconfig Victoria Milhoan
2015-06-17 7:27 ` Steffen Trumtrar
2015-07-24 17:14 ` Horia Geantă [this message]
2015-07-25 1:43 ` Herbert Xu
2015-06-15 23:52 ` [PATCH RFC 07/11] crypto: caam - Unmap data prior to displaying data in print statements Victoria Milhoan
2015-06-15 23:52 ` [PATCH RFC 08/11] crypto: caam - improve initalization for context state saves Victoria Milhoan
2015-06-16 6:41 ` Herbert Xu
2015-06-15 23:52 ` [PATCH RFC 09/11] crypto: caam - Fix incorrect size when DMA unmapping buffer Victoria Milhoan
2015-06-16 6:41 ` Herbert Xu
2015-06-15 23:52 ` [PATCH RFC 10/11] crypto: caam - Provide correct value to iounmap() in controller driver Victoria Milhoan
2015-06-16 6:41 ` Herbert Xu
2015-06-15 23:52 ` [PATCH RFC 11/11] crypto: caam - fix RNG buffer cache alignment Victoria Milhoan
2015-06-16 6:41 ` Herbert Xu
2015-06-16 0:34 ` [PATCH RFC 00/11] crypto: caam - Add i.MX6 support to the Freescale CAAM driver Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B27277.2010403@freescale.com \
--to=horia.geanta@freescale.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=ruchika.gupta@freescale.com \
--cc=s.trumtrar@pengutronix.de \
--cc=vicki.milhoan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.