From: Laszlo Ersek <lersek@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Andreas Faerber <afaerber@suse.de>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.4-rc3 3/3] target-i386: wake up processors that receive an SMI
Date: Fri, 24 Jul 2015 20:22:44 +0200 [thread overview]
Message-ID: <55B28274.2030704@redhat.com> (raw)
In-Reply-To: <1437761762-19798-4-git-send-email-lersek@redhat.com>
On 07/24/15 20:16, Laszlo Ersek wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> An SMI should definitely wake up a processor in halted state!
> This lets OVMF boot with SMM on multiprocessor systems, although
> it halts very soon after that with a "CpuIndex != BspIndex"
> assertion failure.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Andreas Faerber <afaerber@suse.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> target-i386/cpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 7a779b1..ee7b4ac 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -3134,6 +3134,7 @@ static bool x86_cpu_has_work(CPUState *cs)
> return ((cs->interrupt_request & CPU_INTERRUPT_HARD) &&
> (env->eflags & IF_MASK)) ||
> (cs->interrupt_request & (CPU_INTERRUPT_NMI |
> + CPU_INTERRUPT_SMI |
> CPU_INTERRUPT_INIT |
> CPU_INTERRUPT_SIPI |
> CPU_INTERRUPT_MCE)) ||
>
My bad, please disregard this one patch in the series -- an improved
version has already been committed as
a9bad65d2c1f61af74ce2ff43238d4b20bf81c3a.
Sorry about the noise (but please do pick up the first two patches).
Thanks!
Laszlo
next prev parent reply other threads:[~2015-07-24 18:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 18:15 [Qemu-trivial] [PATCH for-2.4-rc3 0/3] a tiny bit late SMM fixups Laszlo Ersek
2015-07-24 18:15 ` [Qemu-devel] " Laszlo Ersek
2015-07-24 18:16 ` [Qemu-trivial] [PATCH for-2.4-rc3 1/3] hw/acpi/ich9: clear smi_en on reset Laszlo Ersek
2015-07-24 18:16 ` [Qemu-devel] " Laszlo Ersek
2015-07-27 9:34 ` [Qemu-trivial] " Igor Mammedov
2015-07-27 9:34 ` Igor Mammedov
2015-07-24 18:16 ` [Qemu-trivial] [PATCH for-2.4-rc3 2/3] hw/acpi/ich9: clean up stale comment about KVM not supporting SMM Laszlo Ersek
2015-07-24 18:16 ` [Qemu-devel] " Laszlo Ersek
2015-07-27 9:43 ` [Qemu-trivial] " Igor Mammedov
2015-07-27 9:43 ` Igor Mammedov
2015-07-24 18:16 ` [Qemu-devel] [PATCH for-2.4-rc3 3/3] target-i386: wake up processors that receive an SMI Laszlo Ersek
2015-07-24 18:22 ` Laszlo Ersek [this message]
2015-07-27 19:11 ` [Qemu-trivial] [PATCH for-2.4-rc3 0/3] a tiny bit late SMM fixups Michael Tokarev
2015-07-27 19:11 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B28274.2030704@redhat.com \
--to=lersek@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.