All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Ander Conselvan De Oliveira <conselvan2@gmail.com>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v1.1 1/5] drm/i915: Handle return value in intel_pin_and_fence_fb_obj, v2.
Date: Sun, 26 Jul 2015 09:24:09 +0200	[thread overview]
Message-ID: <55B48B19.9070107@linux.intel.com> (raw)
In-Reply-To: <1437744387.5172.10.camel@gmail.com>

Op 24-07-15 om 15:26 schreef Ander Conselvan De Oliveira:
> On Tue, 2015-07-21 at 16:09 +0200, Maarten Lankhorst wrote:
>> -EDEADLK has special meaning in atomic, but get_fence may call
>> i915_find_fence_reg which can return -EDEADLK.
>>
>> This has special meaning in the atomic world, so convert the error
>> to -EBUSY for this case.
> Doesn't this change the behavior of intel_crtc_page_flip() slightly? It
> now would return -EBUSY to user space if it can't find a fence instead
> of -EDEADLK. Not sure if that is a problem though. I don't expect user
> space would actually check for -EDEADLK.
>
It would, but if we ever make page_flip atomic we will have to do something like this anyway..

~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-07-26  7:24 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 12:57 [PATCH 0/5] drm/i915: Make waiting interruptible Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 1/5] drm/i915: Handle return value in intel_pin_and_fence_fb_obj Maarten Lankhorst
2015-07-21 11:31   ` Chris Wilson
2015-07-21 14:09     ` [PATCH v1.1 1/5] drm/i915: Handle return value in intel_pin_and_fence_fb_obj, v2 Maarten Lankhorst
2015-07-24 13:26       ` Ander Conselvan De Oliveira
2015-07-24 14:02         ` Chris Wilson
2015-07-26  7:24         ` Maarten Lankhorst [this message]
2015-07-16 12:57 ` [PATCH 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state Maarten Lankhorst
2015-07-16 14:13   ` [PATCH v1.1 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state, v2 Maarten Lankhorst
2015-07-22 13:23     ` Rob Clark
2015-07-27  7:53       ` [Intel-gfx] " Daniel Vetter
2015-07-27 11:07         ` Maarten Lankhorst
2015-07-27 11:14           ` Daniel Vetter
2015-07-27 11:55             ` [Intel-gfx] " Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 3/5] drm/i915: Make prepare_plane_fb fully interruptible Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic Maarten Lankhorst
2015-07-21 11:35   ` Chris Wilson
2015-07-21 12:38     ` Maarten Lankhorst
2015-07-21 12:40       ` Chris Wilson
2015-07-21 12:47         ` Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 5/5] drm/i915: Make wait_for_flips interruptible Maarten Lankhorst
2015-07-20 14:52   ` Maarten Lankhorst
2015-07-21  6:51     ` Daniel Vetter
2015-07-21  8:02       ` Maarten Lankhorst
2015-07-21 11:26   ` Chris Wilson
2015-07-21 12:33     ` Maarten Lankhorst
2015-07-21 13:31       ` Chris Wilson
2015-07-21 13:59         ` Maarten Lankhorst
2015-07-21 14:39           ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B48B19.9070107@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=conselvan2@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.