All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v4] hwmon: (nct7802) Add autopoint attributes
Date: Mon, 27 Jul 2015 04:05:35 +0000	[thread overview]
Message-ID: <55B5AE0F.5030600@roeck-us.net> (raw)
In-Reply-To: <1437860750-10339-1-git-send-email-const@MakeLinux.com>

Hi Constantine,

On 07/26/2015 04:40 AM, Guenter Roeck wrote:

> Question is if the values above are consistent for you when you reload
> the driver (without updating the pwm values, which I think you did above).
> I am having trouble with both the real target and with my module test code.
> It fails for me with all kernel versions from 3.16 to 4.1 if the regmap
> cache type is set to REGCACHE_RBTREE. I am currently trying to track this down.
>

Confirmed to be a regmap problem with REGCACHE_RBTREE. If a block of registers
is enlarged, the cache bitmap memory size is increased with krealloc().
Unfortunately, krealloc() does not zero out the additional memory, which
means the bitmap indicating which registers are cached includes random values.

I'll submit a patch for that after some more testing. Please resubmit your patch
with the changes I asked for.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2015-07-27  4:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-25 21:45 [lm-sensors] [PATCH v4] hwmon: (nct7802) Add autopoint attributes Constantine Shulyupin
2015-07-25 21:45 ` Constantine Shulyupin
2015-07-26 11:40 ` [lm-sensors] " Guenter Roeck
2015-07-27  4:05 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B5AE0F.5030600@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.