From: a.ryabinin@samsung.com (Andrey Ryabinin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/7] KASAN for arm64
Date: Mon, 27 Jul 2015 11:13:08 +0300 [thread overview]
Message-ID: <55B5E814.2020507@samsung.com> (raw)
In-Reply-To: <1437756119-12817-1-git-send-email-a.ryabinin@samsung.com>
On 07/24/2015 07:41 PM, Andrey Ryabinin wrote:
> - fix memleak in kasan_populate_zero_shadow:
> Following code could leak memory when pgd_populate() is nop:
> void *p = early_alloc(PAGE_SIZE, NUMA_NO_NODE);
> pgd_populate(&init_mm, pgd, p);
It's not a leak actually, because this code is under if (pgd_none(*pgd)).
But gcc complains warns about unused variable p, so this has to be changed anyways.
> This was replaced by:
> pgd_populate(&init_mm, pgd, early_alloc(PAGE_SIZE, NUMA_NO_NODE));
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
David Keitel <dkeitel@codeaurora.org>,
Alexander Potapenko <glider@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Alexey Klimov <klimov.linux@gmail.com>
Subject: Re: [PATCH v4 0/7] KASAN for arm64
Date: Mon, 27 Jul 2015 11:13:08 +0300 [thread overview]
Message-ID: <55B5E814.2020507@samsung.com> (raw)
In-Reply-To: <1437756119-12817-1-git-send-email-a.ryabinin@samsung.com>
On 07/24/2015 07:41 PM, Andrey Ryabinin wrote:
> - fix memleak in kasan_populate_zero_shadow:
> Following code could leak memory when pgd_populate() is nop:
> void *p = early_alloc(PAGE_SIZE, NUMA_NO_NODE);
> pgd_populate(&init_mm, pgd, p);
It's not a leak actually, because this code is under if (pgd_none(*pgd)).
But gcc complains warns about unused variable p, so this has to be changed anyways.
> This was replaced by:
> pgd_populate(&init_mm, pgd, early_alloc(PAGE_SIZE, NUMA_NO_NODE));
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
David Keitel <dkeitel@codeaurora.org>,
Alexander Potapenko <glider@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Alexey Klimov <klimov.linux@gmail.com>
Subject: Re: [PATCH v4 0/7] KASAN for arm64
Date: Mon, 27 Jul 2015 11:13:08 +0300 [thread overview]
Message-ID: <55B5E814.2020507@samsung.com> (raw)
In-Reply-To: <1437756119-12817-1-git-send-email-a.ryabinin@samsung.com>
On 07/24/2015 07:41 PM, Andrey Ryabinin wrote:
> - fix memleak in kasan_populate_zero_shadow:
> Following code could leak memory when pgd_populate() is nop:
> void *p = early_alloc(PAGE_SIZE, NUMA_NO_NODE);
> pgd_populate(&init_mm, pgd, p);
It's not a leak actually, because this code is under if (pgd_none(*pgd)).
But gcc complains warns about unused variable p, so this has to be changed anyways.
> This was replaced by:
> pgd_populate(&init_mm, pgd, early_alloc(PAGE_SIZE, NUMA_NO_NODE));
next prev parent reply other threads:[~2015-07-27 8:13 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 16:41 [PATCH v4 0/7] KASAN for arm64 Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` [PATCH v4 1/7] x86/kasan: generate KASAN_SHADOW_OFFSET in Makefile Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-27 16:40 ` Catalin Marinas
2015-07-27 16:40 ` Catalin Marinas
2015-07-27 16:40 ` Catalin Marinas
2015-07-27 17:52 ` Andrey Ryabinin
2015-07-27 17:52 ` Andrey Ryabinin
2015-07-27 17:52 ` Andrey Ryabinin
2015-07-24 16:41 ` [PATCH v4 2/7] mm: kasan: introduce generic kasan_populate_zero_shadow() Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-27 14:23 ` Yury
2015-07-27 14:23 ` Yury
2015-07-27 14:23 ` Yury
2015-07-27 17:52 ` Andrey Ryabinin
2015-07-27 17:52 ` Andrey Ryabinin
2015-07-27 17:52 ` Andrey Ryabinin
2015-08-10 6:01 ` Aneesh Kumar K.V
2015-08-10 6:01 ` Aneesh Kumar K.V
2015-08-10 6:01 ` Aneesh Kumar K.V
2015-08-10 12:00 ` Andrey Ryabinin
2015-08-10 12:00 ` Andrey Ryabinin
2015-08-10 12:00 ` Andrey Ryabinin
2015-07-24 16:41 ` [PATCH v4 3/7] arm64: introduce VA_START macro - the first kernel virtual address Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` [PATCH v4 4/7] arm64: move PGD_SIZE definition to pgalloc.h Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` [PATCH v4 5/7] arm64: add KASAN support Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-27 15:59 ` Catalin Marinas
2015-07-27 15:59 ` Catalin Marinas
2015-07-27 15:59 ` Catalin Marinas
2015-07-27 17:53 ` Andrey Ryabinin
2015-07-27 17:53 ` Andrey Ryabinin
2015-07-27 17:53 ` Andrey Ryabinin
2015-07-24 16:41 ` [PATCH v4 6/7] ARM64: kasan: print memory assignment Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` [PATCH v4 7/7] x86/kasan: switch to generic kasan_populate_zero_shadow() Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-24 16:41 ` Andrey Ryabinin
2015-07-27 16:57 ` Catalin Marinas
2015-07-27 16:57 ` Catalin Marinas
2015-07-27 16:57 ` Catalin Marinas
2015-07-27 17:53 ` Andrey Ryabinin
2015-07-27 17:53 ` Andrey Ryabinin
2015-07-27 17:53 ` Andrey Ryabinin
2015-07-27 8:13 ` Andrey Ryabinin [this message]
2015-07-27 8:13 ` [PATCH v4 0/7] KASAN for arm64 Andrey Ryabinin
2015-07-27 8:13 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B5E814.2020507@samsung.com \
--to=a.ryabinin@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.