From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZJfoC-000174-Gn
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 06:39:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZJfo9-00055r-0O
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 06:39:00 -0400
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:35304)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZJfo8-00055a-Ok
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 06:38:56 -0400
Received: by wibxm9 with SMTP id xm9so106144629wib.0
	for <qemu-devel@nongnu.org>; Mon, 27 Jul 2015 03:38:55 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1437763343-7980-1-git-send-email-hpoussin@reactos.org>
	<1437763343-7980-3-git-send-email-hpoussin@reactos.org>
	<20150726201105.GA13016@aurel32.net> <55B544AE.7000709@reactos.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55B60A3E.5050502@redhat.com>
Date: Mon, 27 Jul 2015 12:38:54 +0200
MIME-Version: 1.0
In-Reply-To: <55B544AE.7000709@reactos.org>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH for 2.4 2/3] net/dp8393x: specify memory
 operations for PROM PROM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Herv=c3=a9_Poussineau?= <hpoussin@reactos.org>, Aurelien Jarno <aurelien@aurel32.net>
Cc: Leon Alrae <leon.alrae@imgtec.com>, qemu-devel@nongnu.org



On 26/07/2015 22:35, Hervé Poussineau wrote:
> +    memory_region_init_ram(&s->prom, OBJECT(dev),
> +                           "dp8393x-prom", SONIC_PROM_SIZE, &local_err);
> +    if (local_err) {
> +        error_propagate(errp, local_err);
> +        return;
> +    }
> +    memory_region_set_readonly(&s->prom, true);

Yup, this is better.  memory_region_init_rom_device is used whenever you
want to catch writes and do something about them.  For example, flash
devices enable ROMD mode, where reads also go down the MMIO path.

Paolo