All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] f_thor: Dont perform reset at the end of thor
Date: Mon, 27 Jul 2015 12:43:51 +0200	[thread overview]
Message-ID: <55B60B67.9000900@monstr.eu> (raw)
In-Reply-To: <20150424174804.08628e18@amdc2363>

Hi Lukasz,

On 04/24/2015 05:48 PM, Lukasz Majewski wrote:
> Hi Michal,
> 
>> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>>
>> Dont perform reset at the end of thor download
>> if configured to do reset off.
>> Reset may not be required in all cases and hence
>> provided an option to do so.
>>
>> The case would be to download the images to DDR instead
>> of flash device.
>>
>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Changes in v2:
>> - Update commit message with additional description
>>
>>  drivers/usb/gadget/f_thor.c | 7 +++++++
>>  drivers/usb/gadget/f_thor.h | 3 +++
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c
>> index e9a690eff5f1..5c8f6768519c 100644
>> --- a/drivers/usb/gadget/f_thor.c
>> +++ b/drivers/usb/gadget/f_thor.c
>> @@ -123,6 +123,9 @@ static int process_rqt_cmd(const struct rqt_box
>> *rqt) send_rsp(rsp);
>>  		g_dnl_unregister();
>>  		dfu_free_entities();
>> +#ifdef CONFIG_THOR_RESET_OFF
>> +		return RESET_DONE;
>> +#endif
>>  		run_command("reset", 0);
>>  		break;
>>  	case RQT_CMD_POWEROFF:
>> @@ -728,6 +731,10 @@ int thor_handle(void)
>>  
>>  		if (ret > 0) {
>>  			ret = process_data();
>> +#ifdef CONFIG_THOR_RESET_OFF
>> +			if (ret == RESET_DONE)
>> +				break;
>> +#endif
>>  			if (ret < 0)
>>  				return ret;
>>  		} else {
>> diff --git a/drivers/usb/gadget/f_thor.h b/drivers/usb/gadget/f_thor.h
>> index 833a9d24ae7e..83412851dd17 100644
>> --- a/drivers/usb/gadget/f_thor.h
>> +++ b/drivers/usb/gadget/f_thor.h
>> @@ -121,4 +121,7 @@ struct f_thor {
>>  #define F_NAME_BUF_SIZE 32
>>  #define THOR_PACKET_SIZE SZ_1M      /* 1 MiB */
>>  #define THOR_STORE_UNIT_SIZE SZ_32M /* 32 MiB */
>> +#ifdef CONFIG_THOR_RESET_OFF
>> +#define RESET_DONE 0xFFFFFFFF
>> +#endif
>>  #endif /* _USB_THOR_H_ */
> 
> Applied to u-boot-dfu. Thanks
> 

Did you applied this patch?
And also
"usb: gadget: f_thor: Allocate request up to THOR_PACKET_SIZE"

I can't see that patches in you DFU tree.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150727/de27050c/attachment.sig>

  reply	other threads:[~2015-07-27 10:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16  8:38 [U-Boot] [PATCH v2] f_thor: Dont perform reset at the end of thor Michal Simek
2015-04-16  9:31 ` Marek Vasut
2015-04-16  9:41   ` Michal Simek
2015-04-16 10:01     ` Marek Vasut
2015-04-23 11:20       ` Michal Simek
2015-04-24 15:48 ` Lukasz Majewski
2015-07-27 10:43   ` Michal Simek [this message]
2015-08-12 10:37     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B60B67.9000900@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.