All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 for-2.5 05/12] tcg/optimize: track const/copy status separately
Date: Mon, 27 Jul 2015 15:44:01 +0200	[thread overview]
Message-ID: <55B635A1.2060800@redhat.com> (raw)
In-Reply-To: <20150727134032.GN11361@aurel32.net>



On 27/07/2015 15:40, Aurelien Jarno wrote:
> >          temps[dst].next_copy = temps[src].next_copy;
> >          temps[dst].prev_copy = src;
> >          temps[temps[dst].next_copy].prev_copy = dst;
> >          temps[src].next_copy = dst;
>
> Note that the patch doesn't change this part, it's already there in the
> original code.

Understood.

> > This is:
> > 
> >     dst->next = src->next;
> >     dst->prev = src;
> >     dst->next->prev = dst;
> >     src->next = dst;
> 
> Here we just want to insert one element, and thus before
> the insertion we have dst->next = dst->prev = dst.

Ah, you're right.

Paolo

  reply	other threads:[~2015-07-27 13:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 10:55 [Qemu-devel] [PATCH v2 for-2.5 00/12] tcg: improve optimizer Aurelien Jarno
2015-07-27 10:55 ` [Qemu-devel] [PATCH for-2.4 01/12] tcg: correctly mark dead inputs for mov with a constant Aurelien Jarno
2015-07-27 10:55 ` [Qemu-devel] [PATCH for-2.4 02/12] tcg: mark temps as mem_coherent = 0 " Aurelien Jarno
2015-07-27 10:55 ` [Qemu-devel] [PATCH v2 for-2.5 03/12] tcg/optimize: optimize temps tracking Aurelien Jarno
2015-07-27 10:56 ` [Qemu-devel] [PATCH v2 for-2.5 04/12] tcg/optimize: add temp_is_const and temp_is_copy functions Aurelien Jarno
2015-07-27 10:56 ` [Qemu-devel] [PATCH v2 for-2.5 05/12] tcg/optimize: track const/copy status separately Aurelien Jarno
2015-07-27 11:26   ` Paolo Bonzini
2015-07-27 13:40     ` Aurelien Jarno
2015-07-27 13:44       ` Paolo Bonzini [this message]
2015-07-27 10:56 ` [Qemu-devel] [PATCH v2 for-2.5 06/12] tcg/optimize: allow constant to have copies Aurelien Jarno
2015-07-27 10:56 ` [Qemu-devel] [PATCH v2 for-2.5 07/12] tcg: rename trunc_shr_i32 into trunc_shr_i64_i32 Aurelien Jarno
2015-07-27 10:56 ` [Qemu-devel] [PATCH v2 for-2.5 08/12] tcg: don't abuse TCG type in tcg_gen_trunc_shr_i64_i32 Aurelien Jarno
2015-07-27 10:56 ` [Qemu-devel] [PATCH v2 for-2.5 09/12] tcg: implement real ext_i32_i64 and extu_i32_i64 ops Aurelien Jarno
2015-07-27 10:56 ` [Qemu-devel] [PATCH v2 for-2.5 10/12] tcg/optimize: add optimizations for " Aurelien Jarno
2015-07-27 10:56 ` [Qemu-devel] [PATCH v2 for-2.5 11/12] tcg/optimize: do not remember garbage high bits for 32-bit ops Aurelien Jarno
2015-07-29 16:34   ` Aurelien Jarno
2015-07-27 10:56 ` [Qemu-devel] [PATCH v2 for-2.5 12/12] tcg: update README about size changing ops Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B635A1.2060800@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.