All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Matt Fleming <matt@codeblueprint.co.uk>,
	Wim Van Sebroeck <wim@iguana.be>
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jean Delvare <jdelvare@suse.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH 5/5] i2c-i801: fixup regarding watchdog timer
Date: Mon, 27 Jul 2015 07:14:08 -0700	[thread overview]
Message-ID: <55B63CB0.7000302@roeck-us.net> (raw)
In-Reply-To: <1438004292-16382-6-git-send-email-matt@codeblueprint.co.uk>

On 07/27/2015 06:38 AM, Matt Fleming wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Change &array[0] to array since it's the same.
>
> It fixes 80 character limit warning as well.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>

Should be merged into patch 2.

Guenter

> ---
>   drivers/i2c/busses/i2c-i801.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index c79dbe116ccc..e41005927746 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1173,7 +1173,8 @@ static void i801_add_tco(struct i801_priv *priv)
>   	if (!(tco_ctl & TCOCTL_EN))
>   		return;
>
> -	memset(&tco_res[0], 0, sizeof(tco_res));
> +	memset(tco_res, 0, sizeof(tco_res));
> +
>   	res = &tco_res[ICH_RES_IO_TCO];
>   	res->start = tco_base & ~1;
>   	res->end = res->start + 32 - 1;
> @@ -1226,7 +1227,7 @@ static void i801_add_tco(struct i801_priv *priv)
>   	res->flags = IORESOURCE_MEM;
>
>   	pdev = platform_device_register_resndata(&pci_dev->dev, "iTCO_wdt", -1,
> -						 &tco_res[0], 3, &tco_platform_data,
> +						 tco_res, 3, &tco_platform_data,
>   						 sizeof(tco_platform_data));
>   	if (IS_ERR(pdev)) {
>   		dev_warn(&pci_dev->dev, "failed to create iTCO device\n");
>


  reply	other threads:[~2015-07-27 14:14 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 13:38 [PATCH 0/5] iTCO_wdt: Add support for Intel Sunrisepoint Matt Fleming
2015-07-27 13:38 ` [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data Matt Fleming
2015-07-27 13:49   ` Guenter Roeck
2015-07-27 14:19     ` Matt Fleming
2015-07-27 14:24       ` Guenter Roeck
2015-07-28  9:52         ` Matt Fleming
2015-07-27 15:33   ` Lee Jones
2015-07-27 15:33     ` Lee Jones
2015-07-27 15:45     ` Andy Shevchenko
2015-07-27 20:32     ` Matt Fleming
2015-07-27 21:32       ` Lee Jones
2015-07-28  9:16         ` Matt Fleming
2015-07-28  9:46   ` Lee Jones
2015-07-28  9:46     ` Lee Jones
2015-07-28 11:07     ` Matt Fleming
2015-07-28 11:37       ` Lee Jones
2015-07-28 11:37         ` Lee Jones
2015-07-28 12:43         ` Matt Fleming
2015-07-28 15:00           ` Lee Jones
2015-07-28 15:18             ` Guenter Roeck
2015-07-28 15:28               ` Lee Jones
2015-07-28 15:28                 ` Lee Jones
2015-07-28 15:45                 ` Matt Fleming
2015-07-28 15:56                   ` Lee Jones
2015-07-28 17:08                 ` Guenter Roeck
2015-07-28 17:32                   ` Lee Jones
2015-07-28 17:32                     ` Lee Jones
2015-07-28 18:51                     ` Guenter Roeck
2015-07-29  7:30                       ` Lee Jones
2015-07-29  7:30                         ` Lee Jones
2015-07-29  9:04                     ` Jean Delvare
2015-07-29 10:07                       ` Lee Jones
2015-07-29 10:07                         ` Lee Jones
2015-07-28 18:46         ` Aaron Sierra
2015-07-29  7:38           ` Lee Jones
2015-07-29 14:52             ` Aaron Sierra
2015-07-29 15:32               ` Lee Jones
2015-07-29 15:32                 ` Lee Jones
2015-07-29 15:52                 ` Guenter Roeck
2015-07-30  8:51                   ` Lee Jones
2015-07-29 16:20                 ` Aaron Sierra
2015-07-29 16:38                   ` Guenter Roeck
2015-07-29 17:00                     ` Aaron Sierra
2015-07-28 16:50     ` Jean Delvare
2015-07-28 16:50       ` Jean Delvare
2015-07-29  7:27       ` Lee Jones
2015-07-29  7:27         ` Lee Jones
2015-07-29  7:29   ` Jean Delvare
2015-07-29 11:09     ` Matt Fleming
2015-07-27 13:38 ` [PATCH 2/5] i2c: i801: Create iTCO device on newer Intel PCHs Matt Fleming
2015-07-27 14:08   ` Guenter Roeck
     [not found]     ` <55B63B48.2040603-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-07-28  9:34       ` Matt Fleming
2015-07-28  9:34         ` Matt Fleming
2015-07-27 13:38 ` [PATCH 3/5] iTCO_wdt: Add support for TCO on Intel Sunrisepoint Matt Fleming
2015-07-27 14:22   ` Guenter Roeck
2015-07-28 10:13     ` Matt Fleming
2015-07-28 17:03   ` Jean Delvare
2015-07-28 17:03     ` Jean Delvare
2015-07-29 10:45     ` Matt Fleming
2015-07-29 10:45       ` Matt Fleming
2015-07-27 13:38 ` [PATCH 4/5] iTCO_wdt: fixup for the header Matt Fleming
2015-07-27 14:13   ` Guenter Roeck
2015-07-28  9:17     ` Matt Fleming
2015-07-27 13:38 ` [PATCH 5/5] i2c-i801: fixup regarding watchdog timer Matt Fleming
2015-07-27 14:14   ` Guenter Roeck [this message]
2015-07-28  9:17     ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B63CB0.7000302@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jdelvare@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matt@codeblueprint.co.uk \
    --cc=mika.westerberg@linux.intel.com \
    --cc=wim@iguana.be \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.