From: "Andreas Färber" <afaerber@suse.de>
To: Pavel Fedin <p.fedin@samsung.com>,
'Markus Armbruster' <armbru@redhat.com>
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>,
'Peter Crosthwaite' <peter.crosthwaite@xilinx.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement
Date: Mon, 27 Jul 2015 16:57:17 +0200 [thread overview]
Message-ID: <55B646CD.8010808@suse.de> (raw)
In-Reply-To: <003201d0c879$8fced800$af6c8800$@samsung.com>
Hi,
Am 27.07.2015 um 16:36 schrieb Pavel Fedin:
>> Do we really want '#' in property names? Elsewhere, we require names to
>> be id_wellformed().
>
> I already asked this question to Andreas but got no single reply from him. My initial idea was to leave '[*]' as a suffix for this magic property. He only told that he doesn't like it.
And I was waiting for replies on your suggestion, as I had concerns
about that '#'.
> I am absolutely fine with absolutely anything. Suggest what you like and i'll change it.
Paolo suggested ...-count on #qemu, but I would prefer ...-max or so, as
the number could differ when some property gets deleted.
On the other hand, since this is not a user-added property, using a
reserved character such as '#' would avoid clashes with user-added
properties, as long as tools handle accessing that property okay.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-07-27 14:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 9:38 [Qemu-devel] [PATCH v4 0/2] QOM: object_property_add() performance improvement Pavel Fedin
2015-07-14 9:39 ` [Qemu-devel] [PATCH v4 1/2] QOM: Introduce object_property_add_single() Pavel Fedin
2015-07-14 9:39 ` [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement Pavel Fedin
2015-07-27 11:42 ` Daniel P. Berrange
2015-07-27 14:36 ` Pavel Fedin
2015-07-27 13:03 ` Markus Armbruster
2015-07-27 13:23 ` Daniel P. Berrange
2015-07-27 13:46 ` Paolo Bonzini
2015-07-27 14:36 ` Pavel Fedin
2015-07-27 14:57 ` Andreas Färber [this message]
2015-07-27 15:06 ` Paolo Bonzini
2015-07-27 15:09 ` Paolo Bonzini
2015-07-27 15:19 ` Pavel Fedin
2015-07-27 15:22 ` Paolo Bonzini
2015-07-28 6:45 ` Pavel Fedin
2015-07-28 7:06 ` Paolo Bonzini
2015-07-27 11:19 ` [Qemu-devel] [PATCH v4 0/2] " Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B646CD.8010808@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=p.fedin@samsung.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.