From mboxrd@z Thu Jan 1 00:00:00 1970 From: a.ryabinin@samsung.com (Andrey Ryabinin) Date: Mon, 27 Jul 2015 20:53:26 +0300 Subject: [PATCH v4 5/7] arm64: add KASAN support In-Reply-To: <20150727155922.GB350@e104818-lin.cambridge.arm.com> References: <1437756119-12817-1-git-send-email-a.ryabinin@samsung.com> <1437756119-12817-6-git-send-email-a.ryabinin@samsung.com> <20150727155922.GB350@e104818-lin.cambridge.arm.com> Message-ID: <55B67016.6090402@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/27/2015 06:59 PM, Catalin Marinas wrote: > On Fri, Jul 24, 2015 at 07:41:57PM +0300, Andrey Ryabinin wrote: >> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile >> index 4d2a925..2cacf55 100644 >> --- a/arch/arm64/Makefile >> +++ b/arch/arm64/Makefile >> @@ -40,6 +40,12 @@ else >> TEXT_OFFSET := 0x00080000 >> endif >> >> +# KASAN_SHADOW_OFFSET = VA_START + (1 << (VA_BITS - 3)) - (1 << 61) >> +KASAN_SHADOW_OFFSET := $(shell printf "0x%x\n" $$(( \ >> + (-1 << $(CONFIG_ARM64_VA_BITS)) \ >> + + (1 << ($(CONFIG_ARM64_VA_BITS) - 3)) \ >> + - (1 << (64 - 3)) )) ) > > Does this work with any POSIX shell? Do we always have a 64-bit type? > As I wasn't sure about this, I suggested awk (or perl). > Ok, It will be safer to use 32-bit arithmetic. I've checked this on 32-bit bash, however this doesn't guarantee that it works with any other version of bash or another shell. >> +static void __init clear_pgds(unsigned long start, >> + unsigned long end) >> +{ >> + /* >> + * Remove references to kasan page tables from >> + * swapper_pg_dir. pgd_clear() can't be used >> + * here because it's nop on 2,3-level pagetable setups >> + */ >> + for (; start && start < end; start += PGDIR_SIZE) >> + set_pgd(pgd_offset_k(start), __pgd(0)); >> +} > > I don't think we need the "start" check, just "start < end". Do you > expect a start == 0 (or overflow)? Right, we don't need this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by kanga.kvack.org (Postfix) with ESMTP id 6D2109003C7 for ; Mon, 27 Jul 2015 13:53:33 -0400 (EDT) Received: by pdbnt7 with SMTP id nt7so55547122pdb.0 for ; Mon, 27 Jul 2015 10:53:33 -0700 (PDT) Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com. [210.118.77.13]) by mx.google.com with ESMTPS id y5si45738558pas.76.2015.07.27.10.53.32 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 27 Jul 2015 10:53:32 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NS500K2HR149N50@mailout3.w1.samsung.com> for linux-mm@kvack.org; Mon, 27 Jul 2015 18:53:28 +0100 (BST) Message-id: <55B67016.6090402@samsung.com> Date: Mon, 27 Jul 2015 20:53:26 +0300 From: Andrey Ryabinin MIME-version: 1.0 Subject: Re: [PATCH v4 5/7] arm64: add KASAN support References: <1437756119-12817-1-git-send-email-a.ryabinin@samsung.com> <1437756119-12817-6-git-send-email-a.ryabinin@samsung.com> <20150727155922.GB350@e104818-lin.cambridge.arm.com> In-reply-to: <20150727155922.GB350@e104818-lin.cambridge.arm.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Catalin Marinas Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, Alexey Klimov , Arnd Bergmann , linux-mm@kvack.org, Linus Walleij , linux-kernel@vger.kernel.org, David Keitel , Alexander Potapenko , Andrew Morton , Dmitry Vyukov On 07/27/2015 06:59 PM, Catalin Marinas wrote: > On Fri, Jul 24, 2015 at 07:41:57PM +0300, Andrey Ryabinin wrote: >> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile >> index 4d2a925..2cacf55 100644 >> --- a/arch/arm64/Makefile >> +++ b/arch/arm64/Makefile >> @@ -40,6 +40,12 @@ else >> TEXT_OFFSET := 0x00080000 >> endif >> >> +# KASAN_SHADOW_OFFSET = VA_START + (1 << (VA_BITS - 3)) - (1 << 61) >> +KASAN_SHADOW_OFFSET := $(shell printf "0x%x\n" $$(( \ >> + (-1 << $(CONFIG_ARM64_VA_BITS)) \ >> + + (1 << ($(CONFIG_ARM64_VA_BITS) - 3)) \ >> + - (1 << (64 - 3)) )) ) > > Does this work with any POSIX shell? Do we always have a 64-bit type? > As I wasn't sure about this, I suggested awk (or perl). > Ok, It will be safer to use 32-bit arithmetic. I've checked this on 32-bit bash, however this doesn't guarantee that it works with any other version of bash or another shell. >> +static void __init clear_pgds(unsigned long start, >> + unsigned long end) >> +{ >> + /* >> + * Remove references to kasan page tables from >> + * swapper_pg_dir. pgd_clear() can't be used >> + * here because it's nop on 2,3-level pagetable setups >> + */ >> + for (; start && start < end; start += PGDIR_SIZE) >> + set_pgd(pgd_offset_k(start), __pgd(0)); >> +} > > I don't think we need the "start" check, just "start < end". Do you > expect a start == 0 (or overflow)? Right, we don't need this. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754643AbbG0Rxb (ORCPT ); Mon, 27 Jul 2015 13:53:31 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:14925 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753537AbbG0Rx3 (ORCPT ); Mon, 27 Jul 2015 13:53:29 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-66-55b67017305c Message-id: <55B67016.6090402@samsung.com> Date: Mon, 27 Jul 2015 20:53:26 +0300 From: Andrey Ryabinin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Catalin Marinas Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, Alexey Klimov , Arnd Bergmann , linux-mm@kvack.org, Linus Walleij , linux-kernel@vger.kernel.org, David Keitel , Alexander Potapenko , Andrew Morton , Dmitry Vyukov Subject: Re: [PATCH v4 5/7] arm64: add KASAN support References: <1437756119-12817-1-git-send-email-a.ryabinin@samsung.com> <1437756119-12817-6-git-send-email-a.ryabinin@samsung.com> <20150727155922.GB350@e104818-lin.cambridge.arm.com> In-reply-to: <20150727155922.GB350@e104818-lin.cambridge.arm.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e/4ZV3xgm2hBttvWFnMWb+GzeLvpGPs Fu+X9TBa7L70jNliwsM2dov2j3uZLU6df8hiMeXPciaLTY+vsVpc3jWHzeLemv+sFi8/nmBx 4PFYM28No8fvX5MYPS739TJ57Jx1l91jwaZSj02fJrF73Lm2h83jxIzfLB6bl9R7fN4kF8AV xWWTkpqTWZZapG+XwJVx4ssploKV3BULl6xha2B8x9HFyMEhIWAi0buIrYuRE8gUk7hwbz2Q zcUhJLCUUeLM0lksEM53RolP0z8zgVTxCmhJPG7fxgpiswioShxfO48ZxGYT0JP4N2s72CRR gQiJt5dPQtULSvyYfI8FxBYR0JW40DYFbCizwHRmiUP7VrODJISBrlh18S4jxLZdjBIrnq5n BElwCjhKXLw2hQ3kVGagDfcvaoGEmQXkJTavecs8gVFgFpIdsxCqZiGpWsDIvIpRNLU0uaA4 KT3XUK84Mbe4NC9dLzk/dxMjJIq+7GBcfMzqEKMAB6MSD+8Fla2hQqyJZcWVuYcYJTiYlUR4 N8ZuCxXiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3fX+xAhgfTEktTs1NSC1CKYLBMHp1QDY0SJ 4LJlN38+WfQ5p2fCWytJnQ28zZ167R0fOvrbvzL8d0iLeLrn8WPl6Nt2Al15WtJKf6ufBWRW rp688ojYwSdKmTPsj536kMk7fVrp1+eCwl4Nd7Xicjgcby/9pHQ9sqVcY6O+QeCm/5vCVX4v 2PRkpu6fQ2+2eZ5q05dy+FH/QXZtqv4nNyWW4oxEQy3mouJEAFzeu0ieAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27/2015 06:59 PM, Catalin Marinas wrote: > On Fri, Jul 24, 2015 at 07:41:57PM +0300, Andrey Ryabinin wrote: >> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile >> index 4d2a925..2cacf55 100644 >> --- a/arch/arm64/Makefile >> +++ b/arch/arm64/Makefile >> @@ -40,6 +40,12 @@ else >> TEXT_OFFSET := 0x00080000 >> endif >> >> +# KASAN_SHADOW_OFFSET = VA_START + (1 << (VA_BITS - 3)) - (1 << 61) >> +KASAN_SHADOW_OFFSET := $(shell printf "0x%x\n" $$(( \ >> + (-1 << $(CONFIG_ARM64_VA_BITS)) \ >> + + (1 << ($(CONFIG_ARM64_VA_BITS) - 3)) \ >> + - (1 << (64 - 3)) )) ) > > Does this work with any POSIX shell? Do we always have a 64-bit type? > As I wasn't sure about this, I suggested awk (or perl). > Ok, It will be safer to use 32-bit arithmetic. I've checked this on 32-bit bash, however this doesn't guarantee that it works with any other version of bash or another shell. >> +static void __init clear_pgds(unsigned long start, >> + unsigned long end) >> +{ >> + /* >> + * Remove references to kasan page tables from >> + * swapper_pg_dir. pgd_clear() can't be used >> + * here because it's nop on 2,3-level pagetable setups >> + */ >> + for (; start && start < end; start += PGDIR_SIZE) >> + set_pgd(pgd_offset_k(start), __pgd(0)); >> +} > > I don't think we need the "start" check, just "start < end". Do you > expect a start == 0 (or overflow)? Right, we don't need this.