Re: [Qemu-devel] [PATCH 1/5] qapi: add comment block before ChardevDummy

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

On 07/03/2015 03:51 AM, Marc-André Lureau wrote:
> This is mainly to please the doc generation that requires comment block
> before the declaration.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  qapi-schema.json | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 106008c..71c894e 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3016,13 +3016,17 @@
>  { 'struct': 'ChardevRingbuf', 'data': { '*size'  : 'int' } }
>  
>  ##
> +# @ChardevDummy

It's worth adding a 'Since: 1.4' comment while at it.

> +##
> +{ 'struct': 'ChardevDummy', 'data': { } }

With that added,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]