All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hung <hpeter@gmail.com>
To: "Jakub Kiciński" <moorray3@wp.pl>, gregkh@linuxfoundation.org
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
	peter_hong@fintek.com.tw,
	Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH 1/1] serial: 8250_pci: add RS485 for F81504/508/512
Date: Tue, 28 Jul 2015 09:44:21 +0800	[thread overview]
Message-ID: <55B6DE75.8090309@gmail.com> (raw)
In-Reply-To: <20150725113545.6bce8038@north>

Hi Jakub Kiciński,

Jakub Kiciński 於 2015/7/25 下午 05:35 寫道:
> Please make sure you correct the rs485 configuration with what you can
> actually support.  Look at 8250_lpc18xx.c as an example.  In your case
> when the function returns it should have SER_RS485_ENABLED and one of
> SER_RS485_RTS_ON_SEND | SER_RS485_RTS_AFTER_SEND set and nothing else
> (or be completely zeroed if SER_RS485_ENABLED was not set).
>

Thanks for your advice, I'll fix it and re-send patch

-- 
With Best Regards,
Peter Hung

      reply	other threads:[~2015-07-28  1:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24  5:55 [PATCH 1/1] serial: 8250_pci: add RS485 for F81504/508/512 Peter Hung
2015-07-25  9:35 ` Jakub Kiciński
2015-07-28  1:44   ` Peter Hung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B6DE75.8090309@gmail.com \
    --to=hpeter@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=moorray3@wp.pl \
    --cc=peter_hong@fintek.com.tw \
    --cc=tom_tsai@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.