From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <don.slutz@gmail.com>
Subject: Re: [PATCH v12 7/8] Add IOREQ_TYPE_VMWARE_PORT
Date: Mon, 27 Jul 2015 22:59:46 -0400
Message-ID: <55B6F022.5030704@Gmail.com>
References: <1435447665-5433-1-git-send-email-Don.Slutz@Gmail.com>
	<1435447665-5433-8-git-send-email-Don.Slutz@Gmail.com>
	<20150701204929.GE27014@l.oracle.com> <5596A266.8020903@Gmail.com>
	<20150707150240.GA23199@l.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150707150240.GA23199@l.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, Eddie Dong <eddie.dong@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, George Dunlap <George.Dunlap@eu.citrix.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org



On 07/07/15 11:02, Konrad Rzeszutek Wilk wrote:
>>>> diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h
>>>> index 7c73089..130eba9 100644
>>>> --- a/xen/include/public/hvm/params.h
>>>> +++ b/xen/include/public/hvm/params.h
>>>> @@ -50,6 +50,8 @@
>>>>  #define HVM_PARAM_PAE_ENABLED  4
>>>>  #define HVM_PARAM_IOREQ_PFN    5
>>>> +/* Extra vmport PFN. */
>>> s/Extra/optional/ ?
>>
>> I do not think "optional" is good to use here.  This PFN is required for
>> QEMU (or any other ioreq server) to handle vmport access.  If you have a
>> better name then "extra", please let me know.
> 
> How about just 'VMWare Port PFN' ?

Will switch to this.

   -Don Slutz

>>
>>    -Don Slutz
>>
>>>> +#define HVM_PARAM_VMPORT_REGS_PFN 35
>>>>  #define HVM_PARAM_BUFIOREQ_PFN 6
>>>>  #define HVM_PARAM_BUFIOREQ_EVTCHN 26
>>>> @@ -187,6 +189,6 @@
>>>>  /* Location of the VM Generation ID in guest physical address space. */
>>>>  #define HVM_PARAM_VM_GENERATION_ID_ADDR 34
>>>> -#define HVM_NR_PARAMS          35
>>>> +#define HVM_NR_PARAMS          36
>>>>  #endif /* __XEN_PUBLIC_HVM_PARAMS_H__ */
>>>> -- 
>>>> 1.8.3.1
>>>>
>>