From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 28 Jul 2015 08:59:35 +0200 Subject: [RFCv2 2/3] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller. In-Reply-To: References: <1437783682-13632-1-git-send-email-moritz.fischer@ettus.com> <1437783682-13632-3-git-send-email-moritz.fischer@ettus.com> <55B5D62D.4010407@monstr.eu> Message-ID: <55B72857.3020108@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 28/07/2015 07:03, Moritz Fischer a ?crit : > Hi Michal, > > I agree we need to be careful with changing the bindings. > > On Sun, Jul 26, 2015 at 11:56 PM, Michal Simek wrote: >> Hi Moritz, >> >> On 07/25/2015 02:21 AM, Moritz Fischer wrote: >>> Signed-off-by: Moritz Fischer >>> --- >>> arch/arm/boot/dts/zynq-7000.dtsi | 43 ++++++++++++- >> >> This patch is nice in general but every change in binding should be >> discussed separately. There is also necessary to wire them up in the >> driver to do action. That's why I think that will be the best just to >> add the code to slcr and keep others untouched. > > Ok, just to clarify: You'd suggest to just add the rstc as child node > to the slcr, > and leave the other nodes untouched? > >> >> For example MACB/GEM is one example. Adding names to this node and >> extending driver to work properly with reset means that all others MACB >> users will be affected. Definitely this patch should be ACKed by Nicolas. Actually, I don't know why a reset property should be added to the macb driver... Bye, -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [RFCv2 2/3] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller. Date: Tue, 28 Jul 2015 08:59:35 +0200 Message-ID: <55B72857.3020108@atmel.com> References: <1437783682-13632-1-git-send-email-moritz.fischer@ettus.com> <1437783682-13632-3-git-send-email-moritz.fischer@ettus.com> <55B5D62D.4010407@monstr.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Moritz Fischer , Michal Simek Cc: p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, Michal Simek , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel , Kumar Gala , =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= List-Id: devicetree@vger.kernel.org Le 28/07/2015 07:03, Moritz Fischer a =C3=A9crit : > Hi Michal, >=20 > I agree we need to be careful with changing the bindings. >=20 > On Sun, Jul 26, 2015 at 11:56 PM, Michal Simek wro= te: >> Hi Moritz, >> >> On 07/25/2015 02:21 AM, Moritz Fischer wrote: >>> Signed-off-by: Moritz Fischer >>> --- >>> arch/arm/boot/dts/zynq-7000.dtsi | 43 ++++++++++++- >> >> This patch is nice in general but every change in binding should be >> discussed separately. There is also necessary to wire them up in the >> driver to do action. That's why I think that will be the best just t= o >> add the code to slcr and keep others untouched. >=20 > Ok, just to clarify: You'd suggest to just add the rstc as child node > to the slcr, > and leave the other nodes untouched? >=20 >> >> For example MACB/GEM is one example. Adding names to this node and >> extending driver to work properly with reset means that all others M= ACB >> users will be affected. Definitely this patch should be ACKed by Nic= olas. Actually, I don't know why a reset property should be added to the macb driver... Bye, --=20 Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753598AbbG1HAp (ORCPT ); Tue, 28 Jul 2015 03:00:45 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:12694 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbbG1HAn (ORCPT ); Tue, 28 Jul 2015 03:00:43 -0400 Message-ID: <55B72857.3020108@atmel.com> Date: Tue, 28 Jul 2015 08:59:35 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Moritz Fischer , Michal Simek CC: , , , , , , Michal Simek , , , linux-arm-kernel , Kumar Gala , =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= Subject: Re: [RFCv2 2/3] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller. References: <1437783682-13632-1-git-send-email-moritz.fischer@ettus.com> <1437783682-13632-3-git-send-email-moritz.fischer@ettus.com> <55B5D62D.4010407@monstr.eu> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 28/07/2015 07:03, Moritz Fischer a écrit : > Hi Michal, > > I agree we need to be careful with changing the bindings. > > On Sun, Jul 26, 2015 at 11:56 PM, Michal Simek wrote: >> Hi Moritz, >> >> On 07/25/2015 02:21 AM, Moritz Fischer wrote: >>> Signed-off-by: Moritz Fischer >>> --- >>> arch/arm/boot/dts/zynq-7000.dtsi | 43 ++++++++++++- >> >> This patch is nice in general but every change in binding should be >> discussed separately. There is also necessary to wire them up in the >> driver to do action. That's why I think that will be the best just to >> add the code to slcr and keep others untouched. > > Ok, just to clarify: You'd suggest to just add the rstc as child node > to the slcr, > and leave the other nodes untouched? > >> >> For example MACB/GEM is one example. Adding names to this node and >> extending driver to work properly with reset means that all others MACB >> users will be affected. Definitely this patch should be ACKed by Nicolas. Actually, I don't know why a reset property should be added to the macb driver... Bye, -- Nicolas Ferre