All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Hans Verkuil <hverkuil@xs4all.nl>,
	Mike Looijmans <mike.looijmans@topic.nl>,
	linux-media@vger.kernel.org
Cc: dragos.bogdan@analog.com, mchehab@osg.samsung.com
Subject: Re: [PATCH] [media] imageon-bridge: Add module license information
Date: Tue, 28 Jul 2015 09:47:42 +0200	[thread overview]
Message-ID: <55B7339E.4010300@metafoo.de> (raw)
In-Reply-To: <55B72BBE.8050902@xs4all.nl>

On 07/28/2015 09:14 AM, Hans Verkuil wrote:
> On 07/28/2015 07:39 AM, Mike Looijmans wrote:
>> Comment header specifies GPL-2, so add a MODULE_LICENSE("GPL v2").
>> This fixes the driver failing to load when built as module:
>>    imageon_bridge: module license 'unspecified' taints kernel.
>>    imageon_bridge: Unknown symbol ...
>> As an extra service, also add a description.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>>   drivers/media/platform/imageon-bridge.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/media/platform/imageon-bridge.c b/drivers/media/platform/imageon-bridge.c
>> index 9550695..a69b6da 100644
>> --- a/drivers/media/platform/imageon-bridge.c
>> +++ b/drivers/media/platform/imageon-bridge.c
>> @@ -317,3 +317,6 @@ static struct platform_driver imageon_bridge_driver = {
>>   	.remove = imageon_bridge_remove,
>>   };
>>   module_platform_driver(imageon_bridge_driver);
>> +
>> +MODULE_DESCRIPTION("Imageon video bridge");
>> +MODULE_LICENSE("GPL v2");
>>
>
> Lovely, but unfortunately the imageon driver is not part of the official linux kernel.
>
> So we can't do anything with this patch.

I've applied the patch, thanks. Hopefully the driver will find its way 
upstream soon.

- Lars


      reply	other threads:[~2015-07-28  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28  5:39 [PATCH] [media] imageon-bridge: Add module license information Mike Looijmans
2015-07-28  7:14 ` Hans Verkuil
2015-07-28  7:47   ` Lars-Peter Clausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B7339E.4010300@metafoo.de \
    --to=lars@metafoo.de \
    --cc=dragos.bogdan@analog.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=mike.looijmans@topic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.