From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Subject: Re: [PATCH 1/2] ARM: dts: Add support for phyCORE-AM335x SoM Date: Tue, 28 Jul 2015 11:29:33 +0300 Message-ID: <55B73D6D.2040801@compulab.co.il> References: <1437035449-26956-1-git-send-email-t.remmet@phytec.de> <20150727143444.GD15004@beef> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150727143444.GD15004@beef> Sender: linux-kernel-owner@vger.kernel.org To: Matt Porter , Teresa Remmet Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Rutland , Pawel Moll , Ian Campbell , Tony Lindgren , Rob Herring , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Kumar Gala List-Id: linux-omap@vger.kernel.org Hi Matt, On 07/27/15 17:34, Matt Porter wrote: > On Thu, Jul 16, 2015 at 10:30:48AM +0200, Teresa Remmet wrote: >> phyCORE-AM335x is a SoM (System on Module) containing >> a AM335x SOC. The module can be connected to different >> carrier boards. >> >> Some hardware parts are configurable on the phyCORE-AM335x. >> So they are disabled on default in this som dtsi file. >> They will be enabled in the board dts files, when populated. >> >> * RAM up to 1GiB >> * PMIC >> * NAND flash up to 1GiB >> * Eth PHY on SOM: 1x RMII >> * SPI NOR flash 8MiB (optional) >> * i2c RTC (optional) >> * i2c EEPROM 4kiB (optional) >> >> Signed-off-by: Teresa Remmet >> --- >> arch/arm/boot/dts/am335x-phycore-som.dtsi | 368 ++++++++++++++++++++++++++++++ >> 1 file changed, 368 insertions(+) >> create mode 100644 arch/arm/boot/dts/am335x-phycore-som.dtsi >> >> diff --git a/arch/arm/boot/dts/am335x-phycore-som.dtsi b/arch/arm/boot/dts/am335x-phycore-som.dtsi >> new file mode 100644 >> index 0000000..4d28fc3 >> --- /dev/null >> +++ b/arch/arm/boot/dts/am335x-phycore-som.dtsi [...] >> +#include "am33xx.dtsi" >> + >> +/ { >> + model = "Phytec AM335x phyCORE"; >> + compatible = "phytec,am335x-phycore-som", "ti,am33xx"; > > One minor thing here...wildcards in compatible strings aren't permitted. > However, family compatibles like "ti,am33xx" that came in before this > was enforced are grandfathered. Ideally, the newly introced board/som > specific strings should not propagate that wildcard. i.e. something > like "phytec,am3352-phycore-som" or whatever is the base family part > on these SOMs. > I'm not sure this is wild card. I tend to think that it is the real name of the som [1], no? http://phytec.com/products/system-on-modules/phycore/am335x/ [...] -- Regards, Igor. From mboxrd@z Thu Jan 1 00:00:00 1970 From: grinberg@compulab.co.il (Igor Grinberg) Date: Tue, 28 Jul 2015 11:29:33 +0300 Subject: [PATCH 1/2] ARM: dts: Add support for phyCORE-AM335x SoM In-Reply-To: <20150727143444.GD15004@beef> References: <1437035449-26956-1-git-send-email-t.remmet@phytec.de> <20150727143444.GD15004@beef> Message-ID: <55B73D6D.2040801@compulab.co.il> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Matt, On 07/27/15 17:34, Matt Porter wrote: > On Thu, Jul 16, 2015 at 10:30:48AM +0200, Teresa Remmet wrote: >> phyCORE-AM335x is a SoM (System on Module) containing >> a AM335x SOC. The module can be connected to different >> carrier boards. >> >> Some hardware parts are configurable on the phyCORE-AM335x. >> So they are disabled on default in this som dtsi file. >> They will be enabled in the board dts files, when populated. >> >> * RAM up to 1GiB >> * PMIC >> * NAND flash up to 1GiB >> * Eth PHY on SOM: 1x RMII >> * SPI NOR flash 8MiB (optional) >> * i2c RTC (optional) >> * i2c EEPROM 4kiB (optional) >> >> Signed-off-by: Teresa Remmet >> --- >> arch/arm/boot/dts/am335x-phycore-som.dtsi | 368 ++++++++++++++++++++++++++++++ >> 1 file changed, 368 insertions(+) >> create mode 100644 arch/arm/boot/dts/am335x-phycore-som.dtsi >> >> diff --git a/arch/arm/boot/dts/am335x-phycore-som.dtsi b/arch/arm/boot/dts/am335x-phycore-som.dtsi >> new file mode 100644 >> index 0000000..4d28fc3 >> --- /dev/null >> +++ b/arch/arm/boot/dts/am335x-phycore-som.dtsi [...] >> +#include "am33xx.dtsi" >> + >> +/ { >> + model = "Phytec AM335x phyCORE"; >> + compatible = "phytec,am335x-phycore-som", "ti,am33xx"; > > One minor thing here...wildcards in compatible strings aren't permitted. > However, family compatibles like "ti,am33xx" that came in before this > was enforced are grandfathered. Ideally, the newly introced board/som > specific strings should not propagate that wildcard. i.e. something > like "phytec,am3352-phycore-som" or whatever is the base family part > on these SOMs. > I'm not sure this is wild card. I tend to think that it is the real name of the som [1], no? http://phytec.com/products/system-on-modules/phycore/am335x/ [...] -- Regards, Igor.