From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [RFC PATCH v3.1 2/2] xsplice: Add hook for build_id
Date: Tue, 28 Jul 2015 16:51:00 +0100
Message-ID: <55B7A4E4.4060804@citrix.com>
References: <1438024817-26942-1-git-send-email-konrad.wilk@oracle.com>
	<1438024817-26942-3-git-send-email-konrad.wilk@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=644318916=Andrew.Cooper3@citrix.com>)
	id 1ZK79x-0002sd-1V
	for xen-devel@lists.xenproject.org; Tue, 28 Jul 2015 15:51:17 +0000
In-Reply-To: <1438024817-26942-3-git-send-email-konrad.wilk@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad@kernel.org>, xen-devel@lists.xenproject.org, msw@amazon.com, aliguori@amazon.com, amesserl@rackspace.com, rick.harris@rackspace.com, paul.voccio@rackspace.com, steven.wilson@rackspace.com, major.hayden@rackspace.com, josh.kearney@rackspace.com, jinsong.liu@alibaba-inc.com, xiantao.zxt@alibaba-inc.com, daniel.kiper@oracle.com, elena.ufimtseva@oracle.com, bob.liu@oracle.com, hanweidong@huawei.com, peter.huangpeng@huawei.com, fanhenglong@huawei.com, liuyingdong@huawei.com, john.liuqiming@huawei.com, jbeulich@suse.com, jeremy@goop.org, dslutz@verizon.com, mpohlack@amazon.com
List-Id: xen-devel@lists.xenproject.org

On 27/07/15 20:20, Konrad Rzeszutek Wilk wrote:
> diff --git a/xen/include/xen/compile.h.in b/xen/include/xen/compile.h.in
> index 440ecb2..939685e 100644
> --- a/xen/include/xen/compile.h.in
> +++ b/xen/include/xen/compile.h.in
> @@ -10,4 +10,5 @@
>  #define XEN_EXTRAVERSION	"@@extraversion@@"
>  
>  #define XEN_CHANGESET		"@@changeset@@"
> +#define XEN_BUILD_ID        "@@changeset@@"

I am not sure putting the changeset into the build id field is sensible.

On the other hand, linking .note.gnu.build-id and exposing it as
XENVER_build_id seems like a very sensible thing to do.  It would
probably make sense to expose it in `xl info`.

~Andrew