From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] AioContext: fix deadlock after aio_context_acquire() race
Date: Tue, 28 Jul 2015 18:17:27 +0200 [thread overview]
Message-ID: <55B7AB17.80102@redhat.com> (raw)
In-Reply-To: <CAJSP0QUmgHD4edUMTgz-OO1+hYRbbS7E8UBM3QrcY0Knd4G0og@mail.gmail.com>
On 28/07/2015 16:08, Stefan Hajnoczi wrote:
>> > v2:
>> > * Free BHs after thread_pool_free(), which calls qemu_bh_delete() [Cornelia]
>> > * Remove assert for leaked BHs since we don't know how many existing cases
>> > there are yet and QEMU 2.4-rc3 is a poor time to risk assertion failures
> The v2 isn't necessary if we apply Paolo's "[PATCH for-2.4] block:
> delete bottom halves before the AioContext is freed" on top of my v1.
> Paolo has audited all BHs so the risk of hitting assertion failures is
> very low.
As you prefer; you're right that there is no use-after-free because of
the way you wrote patch 1/2.
Paolo
prev parent reply other threads:[~2015-07-28 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 12:12 [Qemu-devel] [PATCH v2 0/2] AioContext: fix deadlock after aio_context_acquire() race Stefan Hajnoczi
2015-07-28 12:12 ` [Qemu-devel] [PATCH v2 1/2] AioContext: avoid leaking deleted BHs on cleanup Stefan Hajnoczi
2015-07-28 12:12 ` [Qemu-devel] [PATCH v2 2/2] AioContext: force event loop iteration using BH Stefan Hajnoczi
2015-07-28 14:08 ` [Qemu-devel] [PATCH v2 0/2] AioContext: fix deadlock after aio_context_acquire() race Stefan Hajnoczi
2015-07-28 16:17 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B7AB17.80102@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.