All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@plumgrid.com>
To: Daniel Borkmann <daniel@iogearbox.net>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ebpf, x86: fix general protection fault when tail call is invoked
Date: Tue, 28 Jul 2015 10:02:08 -0700	[thread overview]
Message-ID: <55B7B590.8030600@plumgrid.com> (raw)
In-Reply-To: <23a2630be3c3d41932b9df134f06b9b44671b55e.1438088105.git.daniel@iogearbox.net>

On 7/28/15 6:26 AM, Daniel Borkmann wrote:
> After patch, disassembly:
>
>    [...]
>    9e:   lea    0x80(%rsi,%rdx,8),%rax   <--- CONFIG_LOCKDEP/CONFIG_LOCK_STAT
>          48 8d 84 d6 80 00 00 00
>    a6:   mov    (%rax),%rax
>          48 8b 00
>    [...]
>
>    [...]
>    9e:   lea    0x50(%rsi,%rdx,8),%rax   <--- No CONFIG_LOCKDEP
>          48 8d 84 d6 50 00 00 00
>    a6:   mov    (%rax),%rax
>          48 8b 00
>    [...]
>
> Fixes: b52f00e6a715 ("x86: bpf_jit: implement bpf_tail_call() helper")
> Signed-off-by: Daniel Borkmann<daniel@iogearbox.net>

Thanks for fixing it.
Most of my development is actually with LOCKDEP on, but I don't ever
turn LOCK_STAT on, so sadly missed this 48 byte increase of 80 byte
structure :(

Acked-by: Alexei Starovoitov <ast@plumgrid.com>

  reply	other threads:[~2015-07-28 17:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 13:26 [PATCH net] ebpf, x86: fix general protection fault when tail call is invoked Daniel Borkmann
2015-07-28 17:02 ` Alexei Starovoitov [this message]
2015-07-28 17:17   ` Daniel Borkmann
2015-07-30  0:04 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B7B590.8030600@plumgrid.com \
    --to=ast@plumgrid.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.