From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux Date: Tue, 28 Jul 2015 22:12:21 +0100 Message-ID: <55B7F035.6010201@citrix.com> References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <55B7EECD.8050605@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55B7EECD.8050605@zytor.com> Sender: netdev-owner@vger.kernel.org To: "H. Peter Anvin" , Julien Grall , xen-devel@lists.xenproject.org Cc: linux-fbdev@vger.kernel.org, x86@kernel.org, netdev@vger.kernel.org, Jiri Slaby , Thomas Gleixner , Russell King , linux-scsi@vger.kernel.org, Tomi Valkeinen , stefano.stabellini@eu.citrix.com, Ingo Molnar , linux-input@vger.kernel.org, Jean-Christophe Plagniol-Villard , ian.campbell@citrix.com, "James E.J. Bottomley" , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, Juergen Gross , Wei Liu , Greg Kroah-Hartman , Dmitry Torokhov , linux-kernel@vger.kernel.org, David Vrabel , linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, =?windows-1 List-Id: linux-api@vger.kernel.org On 28/07/15 22:06, H. Peter Anvin wrote: > On 07/28/2015 08:02 AM, Julien Grall wrote: >> Hi all, >> >> This patch series aims to use the memory terminologies described in >> include/linux/mm.h [1] for Linux xen code. >> >> Linux is using mistakenly MFN when GFN is meant, I suspect this is because the >> first support of Xen was for PV. This has brought some misimplementation >> of memory helpers on ARM and make the developper confused about the expected >> behavior. >> >> For instance, with pfn_to_mfn, we expect to get a MFN based on the name. >> Although, if we look at the implementation on x86, it's returning a GFN. >> Most of the callers are also using it this way. >> >> The first 2 patches of this series is ARM related in order to remove >> PV specific helpers which should not be used and fixing the implementation of >> pfn_to_mfn. >> >> The rest of the series is here rename most of the usage in the common code >> of MFN to GFN. I also took the opportunity to replace most of the call to >> pfn_to_gfn in the common code by page_to_gfn avoid construction such >> as pfn_to_gfn(page_to_pfn(...). >> >> Note the one xen-blkfront will be dropped by 64K series [2], I can include it >> if necessary. >> > Can we actually get some documentation for Xen before starting to change > names around? http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb ~Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Date: Tue, 28 Jul 2015 21:12:21 +0000 Subject: Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux Message-Id: <55B7F035.6010201@citrix.com> List-Id: References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <55B7EECD.8050605@zytor.com> In-Reply-To: <55B7EECD.8050605@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: "H. Peter Anvin" , Julien Grall , xen-devel@lists.xenproject.org Cc: linux-fbdev@vger.kernel.org, x86@kernel.org, netdev@vger.kernel.org, Jiri Slaby , Thomas Gleixner , Russell King , linux-scsi@vger.kernel.org, Tomi Valkeinen , stefano.stabellini@eu.citrix.com, Ingo Molnar , linux-input@vger.kernel.org, Jean-Christophe Plagniol-Villard , ian.campbell@citrix.com, "James E.J. Bottomley" , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, Juergen Gross , Wei Liu , Greg Kroah-Hartman , Dmitry Torokhov , linux-kernel@vger.kernel.org, David Vrabel , linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, =?windows-1 On 28/07/15 22:06, H. Peter Anvin wrote: > On 07/28/2015 08:02 AM, Julien Grall wrote: >> Hi all, >> >> This patch series aims to use the memory terminologies described in >> include/linux/mm.h [1] for Linux xen code. >> >> Linux is using mistakenly MFN when GFN is meant, I suspect this is becau= se the >> first support of Xen was for PV. This has brought some misimplementation >> of memory helpers on ARM and make the developper confused about the expe= cted >> behavior. >> >> For instance, with pfn_to_mfn, we expect to get a MFN based on the name. >> Although, if we look at the implementation on x86, it's returning a GFN. >> Most of the callers are also using it this way. >> >> The first 2 patches of this series is ARM related in order to remove >> PV specific helpers which should not be used and fixing the implementati= on of >> pfn_to_mfn. >> >> The rest of the series is here rename most of the usage in the common co= de >> of MFN to GFN. I also took the opportunity to replace most of the call to >> pfn_to_gfn in the common code by page_to_gfn avoid construction such >> as pfn_to_gfn(page_to_pfn(...). >> >> Note the one xen-blkfront will be dropped by 64K series [2], I can inclu= de it >> if necessary. >> > Can we actually get some documentation for Xen before starting to change > names around? http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommitdiff;h=E758ed14f390342= 513405dd766e874934573e6cb ~Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from SMTP.CITRIX.COM (smtp.citrix.com [66.165.176.89]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4AC5E1A0612 for ; Wed, 29 Jul 2015 07:24:59 +1000 (AEST) Message-ID: <55B7F035.6010201@citrix.com> Date: Tue, 28 Jul 2015 22:12:21 +0100 From: Andrew Cooper MIME-Version: 1.0 To: "H. Peter Anvin" , Julien Grall , CC: , , , Jiri Slaby , Thomas Gleixner , "Russell King" , , Tomi Valkeinen , , Ingo Molnar , , "Jean-Christophe Plagniol-Villard" , , "James E.J. Bottomley" , Boris Ostrovsky , , "Juergen Gross" , Wei Liu , Greg Kroah-Hartman , Dmitry Torokhov , , David Vrabel , , , =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <55B7EECD.8050605@zytor.com> In-Reply-To: <55B7EECD.8050605@zytor.com> Content-Type: text/plain; charset="windows-1252" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 28/07/15 22:06, H. Peter Anvin wrote: > On 07/28/2015 08:02 AM, Julien Grall wrote: >> Hi all, >> >> This patch series aims to use the memory terminologies described in >> include/linux/mm.h [1] for Linux xen code. >> >> Linux is using mistakenly MFN when GFN is meant, I suspect this is because the >> first support of Xen was for PV. This has brought some misimplementation >> of memory helpers on ARM and make the developper confused about the expected >> behavior. >> >> For instance, with pfn_to_mfn, we expect to get a MFN based on the name. >> Although, if we look at the implementation on x86, it's returning a GFN. >> Most of the callers are also using it this way. >> >> The first 2 patches of this series is ARM related in order to remove >> PV specific helpers which should not be used and fixing the implementation of >> pfn_to_mfn. >> >> The rest of the series is here rename most of the usage in the common code >> of MFN to GFN. I also took the opportunity to replace most of the call to >> pfn_to_gfn in the common code by page_to_gfn avoid construction such >> as pfn_to_gfn(page_to_pfn(...). >> >> Note the one xen-blkfront will be dropped by 64K series [2], I can include it >> if necessary. >> > Can we actually get some documentation for Xen before starting to change > names around? http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb ~Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew.cooper3@citrix.com (Andrew Cooper) Date: Tue, 28 Jul 2015 22:12:21 +0100 Subject: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux In-Reply-To: <55B7EECD.8050605@zytor.com> References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <55B7EECD.8050605@zytor.com> Message-ID: <55B7F035.6010201@citrix.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28/07/15 22:06, H. Peter Anvin wrote: > On 07/28/2015 08:02 AM, Julien Grall wrote: >> Hi all, >> >> This patch series aims to use the memory terminologies described in >> include/linux/mm.h [1] for Linux xen code. >> >> Linux is using mistakenly MFN when GFN is meant, I suspect this is because the >> first support of Xen was for PV. This has brought some misimplementation >> of memory helpers on ARM and make the developper confused about the expected >> behavior. >> >> For instance, with pfn_to_mfn, we expect to get a MFN based on the name. >> Although, if we look at the implementation on x86, it's returning a GFN. >> Most of the callers are also using it this way. >> >> The first 2 patches of this series is ARM related in order to remove >> PV specific helpers which should not be used and fixing the implementation of >> pfn_to_mfn. >> >> The rest of the series is here rename most of the usage in the common code >> of MFN to GFN. I also took the opportunity to replace most of the call to >> pfn_to_gfn in the common code by page_to_gfn avoid construction such >> as pfn_to_gfn(page_to_pfn(...). >> >> Note the one xen-blkfront will be dropped by 64K series [2], I can include it >> if necessary. >> > Can we actually get some documentation for Xen before starting to change > names around? http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb ~Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux Date: Tue, 28 Jul 2015 22:12:21 +0100 Message-ID: <55B7F035.6010201@citrix.com> References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <55B7EECD.8050605@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , Jiri Slaby , Thomas Gleixner , "Russell King" , , Tomi Valkeinen , , Ingo Molnar , , "Jean-Christophe Plagniol-Villard" , , "James E.J. Bottomley" , Boris Ostrovsky , , "Juergen Gross" , Wei Liu , Greg Kroah-Hartman , Dmitry Torokhov , , David Vrabel , , , =?windows-1 To: "H. Peter Anvin" , Julien Grall , Return-path: Received: from smtp.citrix.com ([66.165.176.89]:23022 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774AbbG1VMf (ORCPT ); Tue, 28 Jul 2015 17:12:35 -0400 In-Reply-To: <55B7EECD.8050605@zytor.com> Sender: netdev-owner@vger.kernel.org List-ID: On 28/07/15 22:06, H. Peter Anvin wrote: > On 07/28/2015 08:02 AM, Julien Grall wrote: >> Hi all, >> >> This patch series aims to use the memory terminologies described in >> include/linux/mm.h [1] for Linux xen code. >> >> Linux is using mistakenly MFN when GFN is meant, I suspect this is because the >> first support of Xen was for PV. This has brought some misimplementation >> of memory helpers on ARM and make the developper confused about the expected >> behavior. >> >> For instance, with pfn_to_mfn, we expect to get a MFN based on the name. >> Although, if we look at the implementation on x86, it's returning a GFN. >> Most of the callers are also using it this way. >> >> The first 2 patches of this series is ARM related in order to remove >> PV specific helpers which should not be used and fixing the implementation of >> pfn_to_mfn. >> >> The rest of the series is here rename most of the usage in the common code >> of MFN to GFN. I also took the opportunity to replace most of the call to >> pfn_to_gfn in the common code by page_to_gfn avoid construction such >> as pfn_to_gfn(page_to_pfn(...). >> >> Note the one xen-blkfront will be dropped by 64K series [2], I can include it >> if necessary. >> > Can we actually get some documentation for Xen before starting to change > names around? http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb ~Andrew