From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752172AbbG1VOq (ORCPT ); Tue, 28 Jul 2015 17:14:46 -0400 Received: from mga09.intel.com ([134.134.136.24]:3407 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbbG1VOp (ORCPT ); Tue, 28 Jul 2015 17:14:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,566,1432623600"; d="scan'208";a="531892243" Message-ID: <55B7F0C1.7050507@intel.com> Date: Wed, 29 Jul 2015 00:14:41 +0300 From: Adrian Hunter User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo , Jiri Olsa CC: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, Namhyung Kim Subject: Re: [RFC/BUG] perf tools: static build fails References: <20150728151347.GA14740@krava.redhat.com> <20150728161139.GE575@kernel.org> In-Reply-To: <20150728161139.GE575@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/2015 7:11 p.m., Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 28, 2015 at 05:13:47PM +0200, Jiri Olsa escreveu: >> hi, >> it's failing on perf-read-vdso32 tool.. >> attached patch fixes that for me > > To build it statically: > > make -C tools/perf O=/tmp/build/perf LDFLAGS=-static install-bin > > Adrian, I wonder if building just these utilities non-statically when we > ask for a static build of the main tool is ok, is it? Not really. Static build works for me, including building perf-read-vdso32 statically, so I am not sure what the problem is? > > - Arnaldo > > > >> jirka >> >> >> --- >> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf >> index 4b58daeff881..a72f790f05e8 100644 >> --- a/tools/perf/Makefile.perf >> +++ b/tools/perf/Makefile.perf >> @@ -370,12 +370,12 @@ $(OUTPUT)perf-%: %.o $(PERFLIBS) >> >> ifndef NO_PERF_READ_VDSO32 >> $(OUTPUT)perf-read-vdso32: perf-read-vdso.c util/find-vdso-map.c >> - $(QUIET_CC)$(CC) -m32 $(filter -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c >> + $(QUIET_CC)$(CC) -m32 $(filter-out -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c >> endif >> >> ifndef NO_PERF_READ_VDSOX32 >> $(OUTPUT)perf-read-vdsox32: perf-read-vdso.c util/find-vdso-map.c >> - $(QUIET_CC)$(CC) -mx32 $(filter -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c >> + $(QUIET_CC)$(CC) -mx32 $(filter-out -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c >> endif >> >> $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)