From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net ([212.227.15.15]:59796 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbbG1XNL (ORCPT ); Tue, 28 Jul 2015 19:13:11 -0400 Message-ID: <55B80C7E.1060409@gmx.de> Date: Wed, 29 Jul 2015 01:13:02 +0200 From: Hartmut Knaack MIME-Version: 1.0 To: "Breana, Tiberiu A" , "linux-iio@vger.kernel.org" CC: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald Subject: Re: [PATCH 6/7] iio:accel:stk8312: code style cleanup References: <4586F61A4A291F4DA44D32824E7C0F4022187F18@IRSMSX109.ger.corp.intel.com> In-Reply-To: <4586F61A4A291F4DA44D32824E7C0F4022187F18@IRSMSX109.ger.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org Breana, Tiberiu A schrieb am 28.07.2015 um 15:45: >> -----Original Message----- >> From: Hartmut Knaack [mailto:knaack.h@gmx.de] >> Sent: Tuesday, July 28, 2015 1:49 AM >> To: linux-iio@vger.kernel.org >> Cc: Jonathan Cameron; Lars-Peter Clausen; Peter Meerwald; Breana, Tiberiu >> A >> Subject: [PATCH 6/7] iio:accel:stk8312: code style cleanup >> >> Adjust some indentation issues to make checkpatch.pl happy in strict mode. >> >> Signed-off-by: Hartmut Knaack > > Comment inline. > >> --- >> drivers/iio/accel/stk8312.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c index >> e3624e2b3ec4..b059a6cabfbb 100644 >> --- a/drivers/iio/accel/stk8312.c >> +++ b/drivers/iio/accel/stk8312.c >> @@ -157,8 +157,7 @@ static int stk8312_otp_init(struct stk8312_data *data) >> if (ret < 0) >> goto exit_err; >> >> - ret = i2c_smbus_write_byte_data(data->client, >> - STK8312_REG_AFECTRL, ret); >> + ret = i2c_smbus_write_byte_data(data->client, >> STK8312_REG_AFECTRL, >> +ret); > > On a single line, this write op would take up 81 chars. > I think it's best to just add 2 tabs to the 2nd line. > Don't worry, it is 80 chars sharp. I have double checked, even checkpatch.pl in strict mode doesn't complain on this one. Just on 2 other points, which I don't consider essential. Thanks, Hartmut >> if (ret < 0) >> goto exit_err; >> msleep(150); >> @@ -453,7 +452,7 @@ static irqreturn_t stk8312_trigger_handler(int irq, void >> *p) >> data->buffer[2] = buffer[2]; >> } else { >> for_each_set_bit(bit, indio_dev->active_scan_mask, >> - indio_dev->masklength) { >> + indio_dev->masklength) { >> ret = stk8312_read_accel(data, bit); >> if (ret < 0) { >> mutex_unlock(&data->lock); >> -- >> 2.4.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >