From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZKLDb-00063U-Ec for mharc-grub-devel@gnu.org; Wed, 29 Jul 2015 02:51:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKLDY-00062F-Cr for grub-devel@gnu.org; Wed, 29 Jul 2015 02:51:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKLDU-0002mn-TP for grub-devel@gnu.org; Wed, 29 Jul 2015 02:51:56 -0400 Received: from johnlane.plus.com ([212.159.104.145]:64157 helo=sodium.amajohn.co.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKLDU-0002mg-Mf for grub-devel@gnu.org; Wed, 29 Jul 2015 02:51:52 -0400 Received: by sodium.amajohn.co.uk (Postfix, from userid 1000) id 53CFE48; Wed, 29 Jul 2015 07:51:46 +0100 (BST) Received: from [10.0.200.1] (hydrogen.amajohn.co.uk [10.0.200.1]) by sodium.amajohn.co.uk (Postfix) with ESMTPSA id 596E55A; Wed, 29 Jul 2015 07:51:45 +0100 (BST) Message-ID: <55B87800.3060802@jelmail.com> Date: Wed, 29 Jul 2015 07:51:44 +0100 From: John Lane User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Andrei Borzenkov Subject: Re: [PATCH 5/5] Cryptomount support for hyphens in UUID References: <1435588260-29456-1-git-send-email-grub@jelmail.com> <1435588260-29456-6-git-send-email-grub@jelmail.com> <20150729060823.136d182a@opensuse.site> In-Reply-To: <20150729060823.136d182a@opensuse.site> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Outbound-Checked: Yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 212.159.104.145 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 06:51:57 -0000 On 29/07/15 04:08, Andrei Borzenkov wrote: > I still believe that generally ignoring hyphens for every future crypto > implementation is wrong. In future we simply should avoid mangling > UUID. So this should be restricted to LUKS only, where the problem > exists. > > Andrei I modified this in response to your earlier feedback so that it doesn't modify the user-supplied data and doesn't have any effect beyond the three places I mentioned. These have no negative impact on uuid values used elesewere. If you don't want to support this fair enough - this can be dropped without impacting the other patches.