From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKLxT-0008O1-DE for qemu-devel@nongnu.org; Wed, 29 Jul 2015 03:39:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKLxS-0000n7-E6 for qemu-devel@nongnu.org; Wed, 29 Jul 2015 03:39:23 -0400 Received: from goliath.siemens.de ([192.35.17.28]:58098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKLxS-0000lF-4I for qemu-devel@nongnu.org; Wed, 29 Jul 2015 03:39:22 -0400 References: <20150728225701.GK3467@type.home> From: Jan Kiszka Message-ID: <55B8831A.6090707@siemens.com> Date: Wed, 29 Jul 2015 09:39:06 +0200 MIME-Version: 1.0 In-Reply-To: <20150728225701.GK3467@type.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , zhanghailiang Cc: Li Zhijian , Stefan Hajnoczi , Jason Wang , peter.huangpeng@huawei.com, Vasiliy Tolstov , qemu-devel , "Gonglei (Arei)" , Stefan Hajnoczi , Yang Hongyang , Dave Gilbert On 2015-07-29 00:57, Samuel Thibault wrote: > Samuel Thibault, le Wed 29 Jul 2015 00:13:57 +0200, a =E9crit : >> I can rebase the patch series over the current master and submit again >> the patches. >=20 > Here it is: >=20 > Hello, >=20 > This is another respin of IPv6 in Qemu -net user mode. >=20 > These patches add ICMPv6, NDP, and make UDP and TCP compatible with > IPv6. We have made some refactoring to make current code compatible wit= h > IPv6. >=20 > Patches 1 to 8 are refactoring of existing code and do not change the b= ehavior, > 9 adds a helper, and 10 to 18 add ipv6 support. Patches 3 and 16 are on= ly > reindents of the resulting code, without code change. >=20 > Difference with version 3 is: > - fix address translation for incoming connection on port forwarding > - incorporate fix 01f7cec for CVE-2014-3640. > - reindentation has been moved into separate patches > - inet6 support in sockaddr_equal has been moved to the ndp support pat= ch > - update first qemu version for the options >=20 > Here is a summary of the patches: >=20 > Refactoring patches: >=20 > [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails > [PATCH 02/18] slirp: Generalizing and neutralizing code before adding > [PATCH 03/18] slirp: Reindent after refactoring > [PATCH 04/18] slirp: Make Socket structure IPv6 compatible > [PATCH 05/18] slirp: Factorizing address translation > [PATCH 06/18] slirp: Factorizing and cleaning solookup() > [PATCH 07/18] slirp: Make udp_attach IPv6 compatible > [PATCH 08/18] slirp: Adding family argument to tcp_fconnect() >=20 > Adding helper: > [PATCH 09/18] qemu/timer.h : Adding function to second scale >=20 > Adding v6 support: > [PATCH 10/18] slirp: Adding IPv6, ICMPv6 Echo and NDP > [PATCH 11/18] slirp: Adding ICMPv6 error sending > [PATCH 12/18] slirp: Adding IPv6 UDP support > [PATCH 13/18] slirp: Factorizing tcpiphdr structure with an union > [PATCH 14/18] slirp: Generalizing and neutralizing various TCP > [PATCH 15/18] slirp: Reindent after refactoring > [PATCH 16/18] slirp: Handle IPv6 in TCP functions > [PATCH 17/18] slirp: Adding IPv6 address for DNS relay > [PATCH 18/18] qapi-schema, qemu-options & slirp: Adding Qemu options >=20 Make sure to add the proper From: of the actual author. Also, some are signed-off by you, others not. As a maintainer, you should sign all of them. Or is there a particular reason (not yet reviewed etc.)? Jan --=20 Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux