From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] vhost: check if vhost has capacity for hotplugged memory
Date: Wed, 29 Jul 2015 10:33:49 +0200 [thread overview]
Message-ID: <55B88FED.8000005@redhat.com> (raw)
In-Reply-To: <20150728170808.0990203f@igors-macbook-pro.local>
On 28/07/2015 17:08, Igor Mammedov wrote:
>> > hw/mem/pc-dimm.c | 7 +++++++
>> > hw/virtio/vhost-backend.c | 23 ++++++++++++++++++++++-
>> > hw/virtio/vhost-user.c | 8 +++++++-
>> > hw/virtio/vhost.c | 21 +++++++++++++++++++++
>> > include/hw/virtio/vhost-backend.h | 2 ++
>> > include/hw/virtio/vhost.h | 1 +
>> > stubs/Makefile.objs | 1 +
>> > stubs/vhost.c | 6 ++++++
>> > 8 files changed, 67 insertions(+), 2 deletions(-)
>> > create mode 100644 stubs/vhost.c
>> >
> ping,
>
> patches are not invasive and fix QEMU crash during memory hotplug
> when running on kernels that have lower vhost memory slots limit.
> Pls consider applying them for 2.4.
I like the approach. For 2.5 we could consider using a
NotifierWithReturn: it can be easily extended to cover KVM as well and
removes the need for the stub.
Paolo
prev parent reply other threads:[~2015-07-29 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 13:49 [Qemu-devel] [PATCH 0/2] vhost: check if vhost has capacity for hotplugged memory Igor Mammedov
2015-07-20 13:49 ` [Qemu-devel] [PATCH 1/2] vhost: add vhost_has_free_slot() interface Igor Mammedov
2015-07-29 10:20 ` Michael S. Tsirkin
2015-07-29 11:26 ` Igor Mammedov
2015-07-20 13:49 ` [Qemu-devel] [PATCH 2/2] pc-dimm: add vhost slots limit check before commiting to hotplug Igor Mammedov
2015-07-28 15:08 ` [Qemu-devel] [PATCH 0/2] vhost: check if vhost has capacity for hotplugged memory Igor Mammedov
2015-07-29 8:33 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B88FED.8000005@redhat.com \
--to=pbonzini@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.