From: Mike Christie <mchristi@redhat.com>
To: David Disseldorp <ddiss@suse.de>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [RFC PATCH 0/5] rbd_tcm cluster COMPARE AND WRITE
Date: Wed, 29 Jul 2015 04:31:41 -0500 [thread overview]
Message-ID: <55B89D7D.1080704@redhat.com> (raw)
In-Reply-To: <1438132552-14673-1-git-send-email-ddiss@suse.de>
On 07/28/2015 08:15 PM, David Disseldorp wrote:
> Hi Mike,
>
> This RFC patch-set expands on your recently proposed cluster API changes
> to add rbd_tcm COMPARE AND WRITE support.
>
> Rather than offloading the entire COMPARE AND WRITE operation to the
> cluster back-end, these changes extend on the existing local semaphore
> usage, to additionally take an RBD COMPARE AND WRITE device lock. RBD
> device lock acquisition is handled via a newly added rbd_tcm workqueue.
>
> I'd appreciate feedback on the overall direction of these changes.
>
I will take a look at them. I just posted my patches too :)
I originally did not want to use cluster locking because I did not want
to have to grab a cluster lock every time we execute the command. I
tried to take advantage that we know which OSD the compare and write is
going to go to, so we can just send the op to it and it can do locking
on the OSD side.
next prev parent reply other threads:[~2015-07-29 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 1:15 [RFC PATCH 0/5] rbd_tcm cluster COMPARE AND WRITE David Disseldorp
2015-07-29 1:15 ` [RFC PATCH 1/5] SQUASH rbd/locking: remove rbd_warn() carriage returns David Disseldorp
2015-07-29 1:15 ` [RFC PATCH 2/5] SQUASH rbd: fix recursive BLK_DEV_RBD_TCM dependency David Disseldorp
2015-07-29 1:15 ` [RFC PATCH 3/5] rbd: export rbd_dev_[un]lock() David Disseldorp
2015-07-29 1:15 ` [RFC PATCH 4/5] drivers/rbd_tcm: Add cluster API CAW locking hooks David Disseldorp
2015-07-29 1:15 ` [RFC PATCH 5/5] target/core_sbc: use cluster API hooks for COMPARE AND WRITE David Disseldorp
2015-07-29 6:58 ` [RFC PATCH 0/5] rbd_tcm cluster " Christoph Hellwig
2015-07-29 9:31 ` Mike Christie [this message]
2015-07-29 10:04 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B89D7D.1080704@redhat.com \
--to=mchristi@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=ddiss@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.