From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 06/12] drm/i915: Make crtc checking use the atomic state. Date: Wed, 29 Jul 2015 14:44:21 +0200 Message-ID: <55B8CAA5.7090500@linux.intel.com> References: <1438000541-3219-1-git-send-email-maarten.lankhorst@linux.intel.com> <1438000541-3219-7-git-send-email-maarten.lankhorst@linux.intel.com> <1438170585.3839.8.camel@gmail.com> <20150729120413.GV16722@phenom.ffwll.local> <1438173110.3839.9.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D4AE7A00B for ; Wed, 29 Jul 2015 05:44:23 -0700 (PDT) In-Reply-To: <1438173110.3839.9.camel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan De Oliveira , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjktMDctMTUgb20gMTQ6MzEgc2NocmVlZiBBbmRlciBDb25zZWx2YW4gRGUgT2xpdmVpcmE6 Cj4gT24gV2VkLCAyMDE1LTA3LTI5IGF0IDE0OjA0ICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3Rl Ogo+PiBPbiBXZWQsIEp1bCAyOSwgMjAxNSBhdCAwMjo0OTo0NVBNICswMzAwLCBBbmRlciBDb25z ZWx2YW4gRGUgT2xpdmVpcmEgCj4+IHdyb3RlOgo+Pj4gT24gTW9uLCAyMDE1LTA3LTI3IGF0IDE0 OjM1ICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPj4+PiBJbnN0ZWFkIG9mIGFsbG9j YXRpbmcgcGlwZV9jb25maWcgb24gdGhlIHN0YWNrIHVzZSB0aGUgb2xkIAo+Pj4+IGNydGNfc3Rh dGUsCj4+Pj4gaXQncyBvbmx5IGdvaW5nIHRvIGZyZWVkIGZyb20gdGhpcyBwb2ludCBvbi4KPj4+ Pgo+Pj4+IEFsbCBjcnRjJ3MgZW5jb2RlcnMgYXJlIG5vdyBvbmx5IGNoZWNrZWQgb25jZSBkdXJp bmcgbW9kZXNldC4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDwK Pj4+PiBtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+Pj4gLS0tCj4+Pj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDExOCArKysrKysrKysrKysrKysr Ky0tLS0KPj4+PiAtLS0tLS0tLS0tLS0tLQo+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgNTYgaW5zZXJ0 aW9ucygrKSwgNjIgZGVsZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIAo+Pj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4+Pj4gaW5kZXggZmJiMjU3ZDQ3MjhjLi5lM2FmZTYxMWE3OGMgMTAw NjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+Pj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+Pj4gQEAgLTExODI5 LDcgKzExODI5LDcgQEAgc3RhdGljIGludCBpbnRlbF9jcnRjX2F0b21pY19jaGVjayhzdHJ1Y3Qg Cj4+Pj4gZHJtX2NydGMgKmNydGMsCj4+Pj4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlw ZV9jb25maWcgPQo+Pj4+ICAJCXRvX2ludGVsX2NydGNfc3RhdGUoY3J0Y19zdGF0ZSk7Cj4+Pj4g IAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUgPSBjcnRjX3N0YXRlLT5zdGF0ZTsKPj4+ PiAtCWludCByZXQsIGlkeCA9IGNydGMtPmJhc2UuaWQ7Cj4+Pj4gKwlpbnQgcmV0Owo+Pj4+ICAJ Ym9vbCBtb2RlX2NoYW5nZWQgPSBuZWVkc19tb2Rlc2V0KGNydGNfc3RhdGUpOwo+Pj4+ICAKPj4+ PiAgCWlmIChtb2RlX2NoYW5nZWQgJiYgIWNoZWNrX2VuY29kZXJfY2xvbmluZyhzdGF0ZSwgCj4+ Pj4gaW50ZWxfY3J0YykpIHsKPj4+PiBAQCAtMTE4MzcsMTAgKzExODM3LDYgQEAgc3RhdGljIGlu dCAKPj4+PiBpbnRlbF9jcnRjX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4+ Pj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4+Pj4gIAl9Cj4+Pj4gIAo+Pj4+IC0JSTkxNV9TVEFURV9X QVJOKGNydGMtPnN0YXRlLT5hY3RpdmUgIT0gaW50ZWxfY3J0Ywo+Pj4+IC0+YWN0aXZlLAo+Pj4+ IC0JCSJbQ1JUQzolaV0gbWlzbWF0Y2ggYmV0d2VlbiBzdGF0ZS0+YWN0aXZlKCVpKSAKPj4+PiBh bmQgY3J0Yy0+YWN0aXZlKCVpKVxuIiwKPj4+PiAtCQlpZHgsIGNydGMtPnN0YXRlLT5hY3RpdmUs IGludGVsX2NydGMtPmFjdGl2ZSk7Cj4+Pj4gLQo+Pj4+ICAJaWYgKG1vZGVfY2hhbmdlZCAmJiAh Y3J0Y19zdGF0ZS0+YWN0aXZlKQo+Pj4+ICAJCWludGVsX2NydGMtPmF0b21pYy51cGRhdGVfd21f cG9zdCA9IHRydWU7Cj4+Pj4gIAo+Pj4+IEBAIC0xMjcyMSwxOSArMTI3MTcsMTYgQEAgY2hlY2tf ZW5jb2Rlcl9zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAKPj4+PiAqZGV2KQo+Pj4+ICAKPj4+PiAg CWZvcl9lYWNoX2ludGVsX2VuY29kZXIoZGV2LCBlbmNvZGVyKSB7Cj4+Pj4gIAkJYm9vbCBlbmFi bGVkID0gZmFsc2U7Cj4+Pj4gLQkJYm9vbCBhY3RpdmUgPSBmYWxzZTsKPj4+PiAtCQllbnVtIHBp cGUgcGlwZSwgdHJhY2tlZF9waXBlOwo+Pj4+ICsJCWVudW0gcGlwZSBwaXBlOwo+Pj4+ICAKPj4+ PiAgCQlEUk1fREVCVUdfS01TKCJbRU5DT0RFUjolZDolc11cbiIsCj4+Pj4gIAkJCSAgICAgIGVu Y29kZXItPmJhc2UuYmFzZS5pZCwKPj4+PiAgCQkJICAgICAgZW5jb2Rlci0+YmFzZS5uYW1lKTsK Pj4+PiAgCj4+Pj4gIAkJZm9yX2VhY2hfaW50ZWxfY29ubmVjdG9yKGRldiwgY29ubmVjdG9yKSB7 Cj4+Pj4gLQkJCWlmIChjb25uZWN0b3ItPmJhc2UuZW5jb2RlciAhPSAmZW5jb2Rlcgo+Pj4+IC0+ YmFzZSkKPj4+PiArCQkJaWYgKGNvbm5lY3Rvci0+YmFzZS5zdGF0ZS0+YmVzdF9lbmNvZGVyIAo+ Pj4+ICE9ICZlbmNvZGVyLT5iYXNlKQo+Pj4+ICAJCQkJY29udGludWU7Cj4+Pj4gIAkJCWVuYWJs ZWQgPSB0cnVlOwo+Pj4+IC0JCQlpZiAoY29ubmVjdG9yLT5iYXNlLmRwbXMgIT0gCj4+Pj4gRFJN X01PREVfRFBNU19PRkYpCj4+Pj4gLQkJCQlhY3RpdmUgPSB0cnVlOwo+Pj4+ICAKPj4+PiAgCQkJ STkxNV9TVEFURV9XQVJOKGNvbm5lY3Rvci0+YmFzZS5zdGF0ZQo+Pj4+IC0+Y3J0YyAhPQo+Pj4+ ICAJCQkJCWVuY29kZXItPmJhc2UuY3J0YywKPj4+PiBAQCAtMTI3NDQsODUgKzEyNzM3LDg2IEBA IGNoZWNrX2VuY29kZXJfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgCj4+Pj4gKmRldikKPj4+PiAg CQkgICAgICJlbmNvZGVyJ3MgZW5hYmxlZCBzdGF0ZSBtaXNtYXRjaCAiCj4+Pj4gIAkJICAgICAi KGV4cGVjdGVkICVpLCBmb3VuZCAlaSlcbiIsCj4+Pj4gIAkJICAgICAhIWVuY29kZXItPmJhc2Uu Y3J0YywgZW5hYmxlZCk7Cj4+Pj4gLQkJSTkxNV9TVEFURV9XQVJOKGFjdGl2ZSAmJiAhZW5jb2Rl ci0+YmFzZS5jcnRjLAo+Pj4+IC0JCSAgICAgImFjdGl2ZSBlbmNvZGVyIHdpdGggbm8gY3J0Y1xu Iik7Cj4+Pj4gLQo+Pj4+IC0JCWFjdGl2ZSA9IGVuY29kZXItPmdldF9od19zdGF0ZShlbmNvZGVy LCAmcGlwZSk7Cj4+Pj4gIAo+Pj4+ICAJCWlmICghZW5jb2Rlci0+YmFzZS5jcnRjKSB7Cj4+Pj4g LQkJCUk5MTVfU1RBVEVfV0FSTihhY3RpdmUsCj4+Pj4gLQkJCSAgICAgImVuY29kZXIgZGV0YWNo ZWQgYnV0IG5vdCB0dXJuZWQgCj4+Pj4gb2ZmLlxuIik7Cj4+Pj4gKwkJCWJvb2wgYWN0aXZlOwo+ Pj4+ICAKPj4+PiAtCQkJY29udGludWU7Cj4+Pj4gKwkJCWFjdGl2ZSA9IGVuY29kZXItPmdldF9o d19zdGF0ZShlbmNvZGVyLCAKPj4+PiAmcGlwZSk7Cj4+Pj4gKwkJCUk5MTVfU1RBVEVfV0FSTihh Y3RpdmUsCj4+Pj4gKwkJCSAgICAgImVuY29kZXIgZGV0YWNoZWQgYnV0IHN0aWxsIGVuYWJsZWQg Cj4+Pj4gb24gcGlwZSAlYy5cbiIsCj4+Pj4gKwkJCSAgICAgcGlwZV9uYW1lKHBpcGUpKTsKPj4+ PiAgCQl9Cj4+Pj4gLQo+Pj4+IC0JCUk5MTVfU1RBVEVfV0FSTihhY3RpdmUgIT0gZW5jb2Rlci0+ YmFzZS5jcnRjCj4+Pj4gLT5zdGF0ZS0+YWN0aXZlLAo+Pj4+IC0JCSAgICAgImVuY29kZXIncyBo dyBzdGF0ZSBkb2Vzbid0IG1hdGNoIHN3IAo+Pj4+IHRyYWNraW5nICIKPj4+PiAtCQkgICAgICIo ZXhwZWN0ZWQgJWksIGZvdW5kICVpKVxuIiwKPj4+PiAtCQkgICAgIGVuY29kZXItPmJhc2UuY3J0 Yy0+c3RhdGUtPmFjdGl2ZSwgYWN0aXZlKTsKPj4+PiAtCj4+Pj4gLQo+Pj4+IC0JCXRyYWNrZWRf cGlwZSA9IHRvX2ludGVsX2NydGMoZW5jb2Rlci0+YmFzZS5jcnRjKQo+Pj4+IC0+cGlwZTsKPj4+ PiAtCQlJOTE1X1NUQVRFX1dBUk4oYWN0aXZlICYmIHBpcGUgIT0gdHJhY2tlZF9waXBlLAo+Pj4+ IC0JCSAgICAgImFjdGl2ZSBlbmNvZGVyJ3MgcGlwZSBkb2Vzbid0IG1hdGNoIgo+Pj4+IC0JCSAg ICAgIihleHBlY3RlZCAlaSwgZm91bmQgJWkpXG4iLAo+Pj4+IC0JCSAgICAgdHJhY2tlZF9waXBl LCBwaXBlKTsKPj4+PiAtCj4+Pj4gIAl9Cj4+Pj4gIH0KPj4+PiAgCj4+Pj4gIHN0YXRpYyB2b2lk Cj4+Pj4gLWNoZWNrX2NydGNfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4+PiArY2hl Y2tfY3J0Y19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAKPj4+PiAqc3RhdGUpCj4+Pj4gIHsKPj4+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+Pj4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YzsKPj4+PiAgCXN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyOwo+Pj4+IC0Jc3RydWN0 IGludGVsX2NydGNfc3RhdGUgcGlwZV9jb25maWc7Cj4+Pj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3Rh dGUgKmNydGNfc3RhdGU7Cj4+Pj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4+Pj4gKwlpbnQg aTsKPj4+PiAgCj4+Pj4gLQlmb3JfZWFjaF9pbnRlbF9jcnRjKGRldiwgY3J0Yykgewo+Pj4+ICsJ Zm9yX2VhY2hfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+Pj4g U28gbm93IHdlIG9ubHkgY2hlY2sgdGhlIHN0YXRlIG9mIGNydGNzIGFmZmVjdGVkIGJ5IHRoZSBt b2Rlc2V0LiBJbiAKPj4+IHRoZQo+Pj4gdW5saWtlbHkgY2FzZSBvZiBhIGJ1ZyB0aGF0IGNoYW5n ZXMgdGhlIGh3IHN0YXRlIG9mIGFub3RoZXIgY3J0YyAKPj4+IHRoYXQKPj4+IHNob3VsZCBoYXZl IGJlZW4gdW5jaGFuZ2VkLCB0aGUgb2xkIGNvZGUgbWlnaHQgY2F0Y2ggdGhlIGlzc3VlIGJ1dCAK Pj4+IHRoZQo+Pj4gbmV3IG9uZSBkb2Vzbid0LiBJc24ndCBpdCBiZXR0ZXIgdG8ganVzdCBjaGVj ayBldmVyeXRoaW5nPwo+PiBXZSBjYW4ndCBzaW5jZSB0aGF0IG90aGVyIGNydGMgbWlnaHQgYmUg ZG9pbmcgc29tZSBvdGhlciBhc3luYyAKPj4gY29tbWl0LiBCdXQKPj4gZXZlbnR1YWxseSB3ZSBz aG91bGQgYmUgZG9pbmcgYSBtb2Rlc2V0IG9uIHRoYXQgb25lIHRvbyBhbmQgc3BvdCB0aGF0Cj4+ IHNvbWV0aGluZyB3ZW50IHdyb25nLgo+IFJpZ2h0LCBJIGZvcmdvdCBhYm91dCBhc3luYy4KPgo+ IFJldmlld2VkLWJ5OiBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGNvbnNlbHZhbjJAZ21h aWwuY29tPgphc3luYyBpcyBub3QgdGhlIG9ubHkgaXNzdWUsIGNydGMtPnN0YXRlIG1heSBkaXNh cHBlYXIgdW5kZXJuZWF0aCB0b28uIDotKQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=