From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH v2 0/6] Generate standalone tests Date: Wed, 29 Jul 2015 15:51:37 +0200 Message-ID: <55B8DA69.7000306@redhat.com> References: <1436806983-29783-1-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, jen@redhat.com To: Andrew Jones , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59654 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525AbbG2Nvm (ORCPT ); Wed, 29 Jul 2015 09:51:42 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 0B86192468 for ; Wed, 29 Jul 2015 13:51:42 +0000 (UTC) In-Reply-To: <1436806983-29783-1-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 13/07/2015 19:02, Andrew Jones wrote: > Add support to convert unit tests to standalone scripts that > can be run outside the framework. This is almost an RFC, but > it doesn't impact the current framework (except for 'make install', > but was that ever used?). The scripting is ugly, but I see value > in having easily distributable unit tests. > > Testing: if you run all standalone tests, concatenating all output > to a file, then that file will match test.log after running > run_tests.sh. Additionally, all prechecks are preserved, i.e. > specific arch and 'check' conditions from unittests.cfg. This is pretty wicked, but it's indeed useful. Applied. :) Paolo > Thanks, > drew > > v2: > - dropped several changes to run_tests.sh [drew] > - pass DRYRUN through env, not config [drew] > - share "run_all", rather than duplicating it [drew] > - rewrote the script, improving it, and reducing ugliness > (well, a bit) [drew] > > Andrew Jones (6): > run_tests.sh: share run_all as for_each_unittest > run: check DRYRUN > scripts: Introduce mkstandalone.sh > arm/unittests.cfg: changes to be more standalone friendly > Makefile: change 'make install' to install standalone tests > standalone: add documentation to README > > .gitignore | 1 + > Makefile | 10 +++- > README | 10 ++++ > arm/run | 12 ++-- > arm/unittests.cfg | 10 ++-- > config/config-arm-common.mak | 2 - > config/config-x86-common.mak | 2 - > run_tests.sh | 46 +-------------- > scripts/functions.bash | 42 ++++++++++++++ > scripts/mkstandalone.sh | 131 +++++++++++++++++++++++++++++++++++++++++++ > x86/run | 11 ++-- > 11 files changed, 212 insertions(+), 65 deletions(-) > create mode 100644 scripts/functions.bash > create mode 100755 scripts/mkstandalone.sh >